Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for providing user-custom-secret for authEncryptSecretKey #199

Closed
TinoSM opened this issue Sep 4, 2023 · 3 comments · Fixed by #201
Closed

Add support for providing user-custom-secret for authEncryptSecretKey #199

TinoSM opened this issue Sep 4, 2023 · 3 comments · Fixed by #201
Assignees

Comments

@TinoSM
Copy link

TinoSM commented Sep 4, 2023

Hi

In AWS CloudFormation CDK we do not want to expose the authEncryptSecretKey in CloudFormation when we instantiate the values yaml in code (this is available in AWS CloudFormation webpage and visible by many with only read-only permissions).

Right now in my code I have (which is exposed both in repos and in cloudformation):

yaml_lakefs = yaml.safe_load(
    f"""
    secrets:
        authEncryptSecretKey: 72e5515097c7adsazczxczxcxzasdasdasd....
    serviceAccount:
        create: false
        name: "{unique_sevice_name}"

Helm Chart will create a Secret named "lakefs" (actually lakefs.fullname) with that value and use it from lakeFS pods. It would be great if users could provide "authEncryptSecretRef" in order for LakeFS to use a user-provided secret (which user can register beforehand using more CDK-friendly mechanisms).

The current approach is still the most developer-friendly for many deployment methods so its still valid, but for AWS CDK its not "valid" in my opinion.

@nopcoder
Copy link
Contributor

nopcoder commented Sep 9, 2023

I'm less familiar withe AWS CloudFormation CDK capabilities.
As a temporary workaround I suggest to check any secerts mechanism you have access to load the secret value and render values.yaml for the chart with the value and not hard coded it into the code itself.

Will look into possible alternatives (possible PR associated) to this issue as part of the chart.

@nopcoder
Copy link
Contributor

@TinoSM please try the latest chart v0.10.1 - use existingSecret to control the name of the secret lakeFS will use.

@TinoSM
Copy link
Author

TinoSM commented Sep 18, 2023

Sorry, was on vacation, tested in 0.12.0 and it works perfect, thanks @nopcoder !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants