Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ETag getObject with If-None-Match #5967

Closed
arielshaqed opened this issue May 28, 2023 · 4 comments · Fixed by #7525
Closed

Add ETag getObject with If-None-Match #5967

arielshaqed opened this issue May 28, 2023 · 4 comments · Fixed by #7525
Labels
area/API Improvements or additions to the API good first issue Good for newcomers new-feature Issues that introduce new feature or capability no stale Using this label will prevent items from being marked as stale performance

Comments

@arielshaqed
Copy link
Contributor

What

Add an optional If-None-Match: "ETag" header to getObject requests. When an ETag is passed, if that ETag is current for the object on that path then return 304 Not Modified.

(Note that for a non-branch ref, we expect the ETag always to match!)

Use-case

My server reads configuration from an object stored on lakeFS. Periodically it needs to refresh the configuration. So it calls getObject. Ideally it would be able to avoid reading the data during a refresh.

Even better: if lakeFS versions before we add this feature simply ignore the header, my server will work with them too!
@arielshaqed arielshaqed added good first issue Good for newcomers area/API Improvements or additions to the API new-feature Issues that introduce new feature or capability performance labels May 28, 2023
@vishalsanfran vishalsanfran mentioned this issue Aug 19, 2023
Closed
@vishalsanfran
Copy link
Contributor

@arielshaqed please review my PR. thanks

@github-actions GitHub Actions
Copy link

This issue is now marked as stale after 90 days of inactivity, and will be closed soon. To keep it, mark it with the "no stale" label.

@github-actions github-actions bot added the stale label Nov 20, 2023
@github-actions GitHub Actions
Copy link

Closing this issue because it has been stale for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 28, 2023
@itaiad200
Copy link
Contributor

Reopening as there's an active PR in progress.

@itaiad200 itaiad200 reopened this Nov 28, 2023
@itaiad200 itaiad200 added no stale Using this label will prevent items from being marked as stale and removed stale labels Nov 28, 2023
@vishalsanfran vishalsanfran mentioned this issue Mar 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/API Improvements or additions to the API good first issue Good for newcomers new-feature Issues that introduce new feature or capability no stale Using this label will prevent items from being marked as stale performance
Projects
None yet
Milestone
No milestone
3 participants
@vishalsanfran @arielshaqed @itaiad200