Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Fatal error when using lakectl local and Git together #6521

Closed
kesarwam opened this issue Sep 1, 2023 · 2 comments · Fixed by #6522
Closed

[Bug]: Fatal error when using lakectl local and Git together #6521

kesarwam opened this issue Sep 1, 2023 · 2 comments · Fixed by #6522
Assignees
Labels
bug Something isn't working contributor

Comments

@kesarwam
Copy link
Contributor

kesarwam commented Sep 1, 2023

What happened?

What actually happened, including error codes if applies.
Received fatal error when using lakectl local and git together

Steps to Reproduce:
Run following commands:

git init ./lakefs_local_git
cd lakefs_local_git
lakectl repo create lakefs://amit-local s3://treeverse-ort-simulation-bucket/amit/amit-local
lakectl local init lakefs://amit-local/main/ .
git commit -m "Initialize lakeFS"
mkdir -p data
echo 'test' > ./data/test.txt
git status
lakectl local status
lakectl local commit ./data -m 'Added data file'
git status

Received following error with last git status command:
fatal: not a git repository (or any of the parent directories): .git

Also, lakectl local commit ./data -m 'Added data file' command uploads .git folder and .gitignore file to lakeFS repository even though these files are not in ./data folder.

Expected behavior

No response

lakeFS version

v0.106.2

How lakeFS is installed

lakeFS Cloud

Affected clients

No response

Relevant log output

No response

Contact details

amit.kesarwani@treeverse.io

@kesarwam kesarwam added bug Something isn't working contributor labels Sep 1, 2023
@kesarwam
Copy link
Contributor Author

kesarwam commented Sep 1, 2023

If I run lakectl local init also on a particular directory then I don't face any problem:
lakectl local init lakefs://amit-local/main/ ./data

So, closing this issue.

@kesarwam kesarwam closed this as completed Sep 1, 2023
@kesarwam
Copy link
Contributor Author

kesarwam commented Sep 1, 2023

it is not a git fatal issue anymore. But we should warn/fail the user who try to use lakectl local on Git repo directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working contributor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants