Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lakectl autocomplete nouns #654

Closed
nopcoder opened this issue Sep 25, 2020 · 14 comments · Fixed by #4320
Closed

lakectl autocomplete nouns #654

nopcoder opened this issue Sep 25, 2020 · 14 comments · Fixed by #4320
Assignees
Labels
area/lakectl Issues related to lakeFS' command line interface (lakectl) good first issue Good for newcomers hacktoberfest Issues that can get you awesome swag! team/versioning-engine Team versioning engine

Comments

@nopcoder
Copy link
Contributor

Have the completions code complete our "nouns" when relevant.
Example:

lakectl fs upload --source <tab> // should suggest files
lakectl repo delete <tab> // should suggest repositories names
@nopcoder nopcoder added good first issue Good for newcomers hacktoberfest Issues that can get you awesome swag! labels Sep 25, 2020
@nopcoder nopcoder added the area/lakectl Issues related to lakeFS' command line interface (lakectl) label Sep 25, 2020
@kichloo
Copy link

kichloo commented Sep 26, 2020

@nopcoder Though I am beginner in this, I can complete it with some help. So, I would like to take this issue.

@nopcoder
Copy link
Contributor Author

nopcoder commented Sep 26, 2020

Sure @kichloo, let me know if you have questions about the issue or the code.

@kichloo
Copy link

kichloo commented Sep 27, 2020

Yes, kindly help me regarding it!

@nopcoder
Copy link
Contributor Author

@kichloo we are using Cobra, here you can find information about the current completion - https://github.com/spf13/cobra/blob/master/shell_completions.md
There you can also find information on how to add "Completion of nouns" to each command we mapped.
Our documentation https://docs.lakefs.io/reference/commands.html#commands-cli-reference holds the reference of all the command, but you can also find the same in the standard project structure based on Cobra.

@avats-dev
Copy link

@kichloo are you still working on this one? Let me know, I want to try this one.

@johnnyaug
Copy link
Contributor

Hey @kichloo, still working on this?

@kichloo
Copy link

kichloo commented Oct 14, 2020

The issue is now open!

@kichloo kichloo removed their assignment Oct 14, 2020
@fumblehool
Copy link
Contributor

Hi, I can work on this if nobody is currently working on it.

@nopcoder
Copy link
Contributor Author

@fumblehool still interested?

@fumblehool
Copy link
Contributor

@nopcoder Unfortunately, I'm unable to work on it right now.

@whoAbhishekSah
Copy link

Hello @nopcoder I would like to work on this issue. Can you assign it to me?

@nopcoder nopcoder assigned nopcoder and whoAbhishekSah and unassigned nopcoder Jan 26, 2021
@arielshaqed
Copy link
Contributor

Unassigning so we can try to get it moving.
Thanks to all current participants!

@siddhant94
Copy link

hi @arielshaqed , is this issue up for grabs? I would like to take a shot if unassigned.
Also, I am trying to build just the lakectl binary using Dockerfile but I run into this error

Step 8/29 : RUN go build -ldflags "-X github.com/treeverse/lakefs/pkg/version.Version=${VERSION}" -o lakectl ./cmd/lakectl
 ---> Running in 9d62437d85d4
pkg/db/migration.go:17:2: no required module provides package github.com/treeverse/lakefs/pkg/ddl; to add it:
        go get github.com/treeverse/lakefs/pkg/ddl
pkg/api/ui_handler.go:18:2: no required module provides package github.com/treeverse/lakefs/pkg/webui; to add it:
        go get github.com/treeverse/lakefs/pkg/webui

@arielshaqed
Copy link
Contributor

hi @arielshaqed , is this issue up for grabs? I would like to take a shot if unassigned.

Hi @siddhant94 ,

All yours, thanks for stepping up to this one! Please let us know if you need any help. Our Slack has a #dev channel that is really good if you prefer instant-messaging conversations.

Also, I am trying to build just the lakectl binary using Dockerfile but I run into this error

This is very odd; I just built the container successfully. Could you please send me:

  1. git status
  2. command used to initiate the build
  3. an entire log of a failed build?

In the meantime: Most of us find it more convenient not to build lakeFS inside a container (we do use the container for deployments, of course). Instead the contribution guide should walk you through installing all the tools that you would need in order to run make build test on your development machine.

Step 8/29 : RUN go build -ldflags "-X github.com/treeverse/lakefs/pkg/version.Version=${VERSION}" -o lakectl ./cmd/lakectl
 ---> Running in 9d62437d85d4
pkg/db/migration.go:17:2: no required module provides package github.com/treeverse/lakefs/pkg/ddl; to add it:
        go get github.com/treeverse/lakefs/pkg/ddl
pkg/api/ui_handler.go:18:2: no required module provides package github.com/treeverse/lakefs/pkg/webui; to add it:
        go get github.com/treeverse/lakefs/pkg/webui

@nopcoder nopcoder added the team/versioning-engine Team versioning engine label Mar 16, 2022
@nopcoder nopcoder linked a pull request Oct 8, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/lakectl Issues related to lakeFS' command line interface (lakectl) good first issue Good for newcomers hacktoberfest Issues that can get you awesome swag! team/versioning-engine Team versioning engine
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants