Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import API of Python Client: "type" field for ImportLocation is not explained #6880

Closed
kesarwam opened this issue Oct 25, 2023 · 3 comments · Fixed by #6886
Closed

Import API of Python Client: "type" field for ImportLocation is not explained #6880

kesarwam opened this issue Oct 25, 2023 · 3 comments · Fixed by #6886
Assignees
@itaiad200
Labels
bug Something isn't working

Comments

@kesarwam
Copy link
Contributor

kesarwam commented Oct 25, 2023 •
edited
Loading

What happened?

Types in ImportLocation are either common_prefix or object but it is not explained in any documentation. If I use object to import a single object by using following ImportLocation then it creates a blank file name:

ImportLocation(type="object", path="s3://sample-dog-images/Annotations/n02085620-Chihuahua/n02085620_10074", destination="json/")

While Import UI doesn't have this type option.

Expected behavior

No response

lakeFS version

1.0.0

How lakeFS is installed

lakeFS Cloud

Affected clients

No response

Relevant log output

No response

Contact details

amit.kesarwani@treeverse.io
@kesarwam kesarwam added bug Something isn't working contributor labels Oct 25, 2023
@itaiad200 itaiad200 self-assigned this Oct 26, 2023
@itaiad200 itaiad200 mentioned this issue Oct 26, 2023
Merged
@itaiad200
Copy link
Contributor

I think the second item issue here ("While Import UI doesn't have this type option.") is covered by #5886

@N-o-Z
Copy link
Member

N-o-Z commented Oct 26, 2023

Currently UI and lakectl support only common_prefix and we might want to mention that in the docs

@kesarwam
Copy link
Contributor Author

and change this doc also: https://github.com/treeverse/lakeFS/blob/master/clients/python/docs/ImportLocation.md

@N-o-Z N-o-Z removed the contributor label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itaiad200 itaiad200

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

6880 import api location docs treeverse/lakeFS
3 participants
@N-o-Z @itaiad200 @kesarwam