Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delta exporter: support export of delta log files with abfss scheme to support unity catalog external tables #7553

Closed
N-o-Z opened this issue Mar 13, 2024 · 4 comments · Fixed by #7554
Assignees

Comments

@N-o-Z
Copy link
Member

N-o-Z commented Mar 13, 2024

While working on #7551 and trying to enable unity exporter on Azure we discovered that in addition to providing the external location as an abfss scheme, we also need to export the delta logs so that the paths are format using this scheme instead of https.

We need to add a flag for the exporter, when using with Azure to decide the format in which to write the paths in the delta log when exporting from lakeFS

@N-o-Z N-o-Z self-assigned this Mar 13, 2024
@ozkatz
Copy link
Collaborator

ozkatz commented Mar 13, 2024

@N-o-Z can’t this be inferred from the storage namespace/external location?

@N-o-Z
Copy link
Member Author

N-o-Z commented Mar 13, 2024

If we translate the path to abfss as a rule we will lose support for delta export for Azure Blob Storage accounts that are not ADLS gen2.I think we need to provide the user the option to choose how to save the paths. AFAIU abfss is a scheme supported only by ADLS Gen2 storage accounts

@ozkatz
Copy link
Collaborator

ozkatz commented Mar 13, 2024

so this is orthogonal to the scheme defined in the repository’s storage namespace?

@N-o-Z
Copy link
Member Author

N-o-Z commented Mar 13, 2024

so this is orthogonal to the scheme defined in the repository’s storage namespace?

I'll need to understand what you mean by orthogonal in this context to answer your question 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants