Wrong UI error when repo name contains underscore (on repo creation)

[itaiad200]

No description provided.

[Sufiyan1997]

@itaiad200 I would like to work on this.

[itaiad200]

@Sufiyan1997 assigned. Feel free to reach out on slack if you need any help.

[Sufiyan1997]

Do I need to change the regex to allow underscores in repository names or just change the error message?

[itaiad200]

Underscores should not be allowed. We should validate the repo name in the UI and display a proper error message before sending the request to the server.

[Sufiyan1997]

I have added client side validation for all 3 fields while creating repository.
Are this validation messages and UI correct?

[itaiad200]

Almost :) It's easiest to point you to the validation on the server side to avoid mismatches.

1. Swagger file:

   lakeFS/swagger.yml

   Line 86 in 00d3eb2

   repository_creation:

2. On the actual creation:

   lakeFS/catalog/cataloger_create_repository.go

   Line 17 in 00d3eb2

   if err := Validate(ValidateFields{

Let me know if something is unclear.