Converted OperatorSubscribeUntil -> takeUntil #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to test certain Subscription states.
There was one key problem with OperatorSubscribeUntil, which is that it had the potential to be incompatible with other Operators. This required you to be careful about when you call it, which isn't great for a library. Switching to takeUntil means that onCompleted will be called when the sequence completes due to a lifecycle event. But that's alright; in most cases it won't change anything. Also, if someone *does* need to terminate without onCompleted, they can manually handle the Subscription and unsubscribe themselves.
dlew
added a commit
that referenced
this pull request
Aug 10, 2015
Converted OperatorSubscribeUntil -> takeUntil
|
For future reference - since I forgot where this change originated from - here's the original issue: ReactiveX/RxAndroid#168 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was one key problem with OperatorSubscribeUntil, which is that it had the potential to be incompatible with other Operators. This required you to be careful about when you call it, which isn't great for a library.
Switching to takeUntil means that onCompleted will be called when the sequence completes due to a lifecycle event. But that's alright; in most cases it won't change anything. Also, if someone does need to terminate without onCompleted, they can manually handle the Subscription and unsubscribe themselves.