rxlifecycle-kotlin module added with bind() syntax #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,4 @@ | |||
| include ':rxlifecycle' | |||
| include ':rxlifecycle', ':rxlifecycle-kotlin' | |||
There was a problem hiding this comment.
Could this be on a newline to match the rest of it?
There was a problem hiding this comment.
of course!
And since kotlin just released, i have to upgrade it
|
all things solved! |
| ``` | ||
|
|
||
| ```java | ||
| myObservable |
There was a problem hiding this comment.
I would just make this a single example instead of two.
There was a problem hiding this comment.
Eh, can deal with this post-merge.
There was a problem hiding this comment.
You want me to create example android project?
There was a problem hiding this comment.
Nah. I was just saying that this is two separate code samples but could just be wrapped into one.
dlew
added a commit
that referenced
this pull request
Feb 16, 2016
rxlifecycle-kotlin module added with bind() syntax
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address reverted #58 , and some nice new syntax
Not sure if any tests will work here.