Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Class about keeps track of the game version #596

Open
Tracked by #597 ...
TheoPannetier opened this issue Sep 23, 2022 · 0 comments
Open
Tracked by #597 ...

Class about keeps track of the game version #596

TheoPannetier opened this issue Sep 23, 2022 · 0 comments
Labels
first A good first issue junior Suitable for junior devs

Comments

@TheoPannetier
Copy link
Contributor

TheoPannetier commented Sep 23, 2022

Users should be able to read which release of the game they are playing, for example v2.0.1.
We should have the game keep this info in class about (later, we can display this on screen via about_view).

I have made a test to enforce this:

  #ifdef FIX_ISSUE_596
  // (596) The About object keeps track of the game version
  {
    about ab;
    std::vector<std::string> version;
    version = ab.get_version();
  }
#endif

The test simply enforces that class about does contain a member function that returns a string, so your goal is to:

  1. create this member function get_version()
  2. ensure it returns a string

Of course, please make the string the current version of the game. You can find the version here in the release tab.

You'll probably need to know the basics of how a class works. If you don't, ask a more experienced member for help :)
Another solution is to look at other already existing cases, e.g. I suggest simply copy-pasting and editing about::get_link_discord() 😉

@TheoPannetier TheoPannetier added first A good first issue junior Suitable for junior devs labels Sep 23, 2022
@TheoPannetier TheoPannetier self-assigned this May 3, 2023
@TheoPannetier TheoPannetier changed the title about keeps track of the game version Class about keeps track of the game version May 3, 2023
@TheoPannetier TheoPannetier removed their assignment May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
first A good first issue junior Suitable for junior devs
Projects
None yet
Development

No branches or pull requests

1 participant