fix: 83 trescanvas component is missing template or render function after 3100 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
userquin
reviewed
Feb 2, 2024
userquin
reviewed
Feb 6, 2024
| // import { TresCanvas } from '#components' | ||
| // import { onMounted, useRenderLoop } from '#imports' | ||
|
|
||
| const { resume } = useRenderLoop() |
There was a problem hiding this comment.
this can be moved inside the onMounted hook (?)
There was a problem hiding this comment.
It can be removed since is a leftover trying to fix the issue you solved.
userquin
reviewed
Feb 7, 2024
danielroe
reviewed
Feb 7, 2024
src/module.ts
Outdated
Comment on lines
107
to
112
| else { | ||
| await addComponent({ | ||
| name: 'TresCanvas', | ||
| filePath: resolver.resolve('./runtime/TresCanvas.client.vue'), | ||
| }) | ||
| } |
There was a problem hiding this comment.
why do we need this if/else?
There was a problem hiding this comment.
why registering the server component without ssr enabled?
There was a problem hiding this comment.
It should not do anything in that case, but it will decrease the need for complexity in the module.
Note that addComponent is synchronous - no need to await it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopefully closes #83 #41 . Thanks @userquin for the fix 🙏🏻 it does work as expected