Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeing selection modal when there's only one neovim pane in the window #7

Closed
dkarter opened this issue Oct 7, 2024 · 2 comments
Closed

Comments

@dkarter
Copy link
Contributor

dkarter commented Oct 7, 2024

Hi!

Thanks for this plugin, it looks really useful :)

I've installed it and have been testing it out, here's my config:
https://github.com/dkarter/dotfiles/blob/eb25d8a90703d524c71dbe09b861e78710999e09/config/tmux/tmux.conf#L251-L253

The way I work, is I have multiple sessions open, and each session will have a neovim instance in one of the tabs (tmux windows).

I noticed that tmux-open-nvim will show me a modal for selecting an instance, even if there's only one neovim instance in the current window. I'm not sure if this is intended, but it feels unnecessary to me - I most likely want to open the file in the current window and not in some other session.

Here's a quick video showing the problem:

CleanShot.2024-10-07.at.00.03.49.mp4

I have another session with a single window that has two nvims in it, and those are picked up in the pop up window for some reason.

If I close the other session, it works as I expect:

CleanShot.2024-10-07.at.00.07.02.mp4
@trevarj trevarj closed this as completed in 1a590b2 Oct 7, 2024
@trevarj
Copy link
Owner

trevarj commented Oct 7, 2024

Thanks for reporting!

Indeed it was pretty buggy and my original intention was to make it not span across tmux sessions, which seems like overkill.

I pushed a commit that should fix it. Keep your config the same and give it a try.

@dkarter
Copy link
Contributor Author

dkarter commented Oct 8, 2024

Oh that's perfect, thank you so much! Confirmed the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants