Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What does * (ns) mean? #129

Closed
JohannesWiesner opened this issue Aug 29, 2023 · 3 comments
Closed

What does * (ns) mean? #129

JohannesWiesner opened this issue Aug 29, 2023 · 3 comments

Comments

@JohannesWiesner
Copy link

I ran multiple comparison corrections using Benjamini-Hochberg procedure. Some of my tests have a * (ns) symbol. Wonder what this means? It does also not appear in the table that is printed to console before running the tests:

p-value annotation legend:
      ns: p <= 1.00e+00
       *: 1.00e-02 < p <= 5.00e-02
      **: 1.00e-03 < p <= 1.00e-02
     ***: 1.00e-04 < p <= 1.00e-03
    ****: p <= 1.00e-04
@trevismd
Copy link
Owner

trevismd commented Oct 1, 2023

Sorry about the delay @JohannesWiesner ...

It means that due to the correction method applied, your "*" which means between .01 and .05 is actually statistically not significant (ns).
You can see the correction_formatargument of Annotator.configure for changing this rendering (for example to simply ns with .configure(correction_format="replace"). You'll just have to be mindful that the legend will not be accurate anymore (but you see the (ns) in the statistical test result).

@JohannesWiesner
Copy link
Author

But wouldn't it be better if the * would just completely disappear by default if it doesn't survive the multiple comparisons correction?

@trevismd
Copy link
Owner

trevismd commented Oct 6, 2023

Opened a discussion around this suggestion: #137
(Trying to progressively clean up the issues vs howtos vs why-dont-we ;))

@trevismd trevismd closed this as completed Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants