Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use src/ folder for package #150

Open
sepro opened this issue May 14, 2024 · 0 comments
Open

Use src/ folder for package #150

sepro opened this issue May 14, 2024 · 0 comments

Comments

@sepro
Copy link
Contributor

sepro commented May 14, 2024

Someone recently pointed out in one of my packages that currently it is considered best practice to have a src/ folder and include the module's code there. Which is correct and some details can be found here. Two users also indicated issues when installing packages using alternative tools (e.g. uv, ... though I haven't been able to replicate that, take that with a healthy dose of skepticism).

This would require moving the statannotations folder to src/statannotations and making the corresponding changes to setup.py and config for unit-tests and github actions.

Happy to provide a PR, if there is interest and it wouldn't cause issues I haven't considered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant