Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comparisons_correction annotation #99

Closed
mahmood83 opened this issue Dec 24, 2022 · 1 comment
Closed

comparisons_correction annotation #99

mahmood83 opened this issue Dec 24, 2022 · 1 comment

Comments

@mahmood83
Copy link

I set ‘comparisons_correction=BH’, but the p-values report and annotate equal to the case ‘comparisons_correction=None’. Specifically, in the example notebook, section 'Multiple comparisons', for Mann-Whitney-Wilcoxon test two-sided with/without Benjamini-Hochberg correction, the reported and annotated p-values are equal.
Indeed, it seems, only comparisons_correction="Bonferroni" annotates and reports correctly.

@trevismd
Copy link
Owner

Hello @mahmood83 , thanks for your question.
Not all comparisons correction methods alter the pvalue, they however change the threshold for a pvalue to be considered statistically significant at the defined alpha.
Therefore, you can see in the examples you cite that instead of *, we get * (ns) even though the pvalue is the same.
You can read a more detailed discussion about this in #30, and a way to have only ns on the plot instead was implemented in #31.

@trevismd trevismd closed this as completed Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants