Skip to content
This repository has been archived by the owner on Nov 23, 2023. It is now read-only.

Implement EthereumSignMessage #66

Closed
LogvinovLeon opened this issue Aug 8, 2017 · 8 comments
Closed

Implement EthereumSignMessage #66

LogvinovLeon opened this issue Aug 8, 2017 · 8 comments

Comments

@LogvinovLeon
Copy link

LogvinovLeon commented Aug 8, 2017

It's already done in the newest firmware: trezor/trezor-mcu#189

@prusnak
Copy link
Member

prusnak commented Aug 8, 2017

Would you like to try to implement it in connect? The API is very similar to Bitcoin Sign/Verify Message.

@prusnak
Copy link
Member

prusnak commented Aug 8, 2017

@LogvinovLeon
Copy link
Author

I've already implemented it for myself locally, but it's hard to test it, cause it also meeds to be implemented in popup.js, which is fetched from your s3 bucket.
I created s3 bucket for myself and also implemented it in popup.js and redirected connect to this bucket, but I'm still getting Could not establish connection errors.
I guess it might have smth to do with me using a different origin and you checking the signatures from config_signed.bin.

TL;DR I'll start a PR in this repo, but i'm unable to test it.

@prusnak
Copy link
Member

prusnak commented Aug 8, 2017

No worries about testing, we will test it.

@prusnak
Copy link
Member

prusnak commented Aug 8, 2017

Let's continue the discussion in #67. Closing this

@prusnak prusnak closed this as completed Aug 8, 2017
@lyddream
Copy link

Is ethereumSignMessage the same as ethereum eth_sign?
does ethereumSignMessage method add ethereum prefix(\x19Ethereum Signed Message:\n) during sign progress?

@lyddream
Copy link

const hash = hashPersonalMessage(toBuffer('test')).
const sig = ecsign(hash,privateKey)

I use the above method to sign a message ,but I can' t get the same result from ethereumSignMessage?

@prusnak
Copy link
Member

prusnak commented Mar 15, 2018

Ethereum Sign Message is broken across implementation. There are many incompatible standards. We will implement one which is universally adopted. Until then let's consider this as unimplemented.

Closing as duplicate of trezor/trezor-core#122

@prusnak prusnak reopened this Mar 15, 2018
@prusnak prusnak closed this as completed Mar 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants