-
-
Notifications
You must be signed in to change notification settings - Fork 262
Implement EthereumSignMessage #66
Comments
Would you like to try to implement it in connect? The API is very similar to Bitcoin Sign/Verify Message. |
I've already implemented it for myself locally, but it's hard to test it, cause it also meeds to be implemented in popup.js, which is fetched from your s3 bucket. TL;DR I'll start a PR in this repo, but i'm unable to test it. |
No worries about testing, we will test it. |
Let's continue the discussion in #67. Closing this |
Is ethereumSignMessage the same as ethereum eth_sign? |
const hash = hashPersonalMessage(toBuffer('test')). I use the above method to sign a message ,but I can' t get the same result from ethereumSignMessage? |
Ethereum Sign Message is broken across implementation. There are many incompatible standards. We will implement one which is universally adopted. Until then let's consider this as unimplemented. Closing as duplicate of trezor/trezor-core#122 |
It's already done in the newest firmware: trezor/trezor-mcu#189
The text was updated successfully, but these errors were encountered: