Support EIP2718 EIP1559 transactions

[ligi]

In the upcoming Ethereum hardfork a new style of transactions is introduced via EIP1559. It leverages the new Typed Transaction Envelope (EIP2718).
It would be great if TREZOR would support this new style of transactions.
Even though legacy transactions will still be supported - TREZOR users would overpay for transaction fees.

[brad-decker]

Also need this on the MetaMask team to support users who use Trezor.

[matejcik]

this becomes relevant as of the London hardfork, planned for July 2021

[prusnak]

this becomes relevant as of the London hardfork, planned for July 2021

Is the old transaction format still suported after the hardfork?

Edit: Nevermind, the OP says it does.

[prusnak]

TREZOR users would overpay for transaction fees.

How much percent overpay are we talking here for simple transfer and simple ERC20 transfer?

[brad-decker]

@prusnak the way that backward compatibility works is that gasPrice is used as the maxFeePerGas and the lack of a maxPriorityFeePerGas means that if the transaction specifies gasPrice of 100 gwei and the baseFee for the block is only 48 gwei then 52 gwei per gas is paid to the miner. Under EIP1559 the fullness of
The blocks determines both the baseFee of the next block and the amount necessary for a tip to be included in a block.

So the answer to your question is: it varies by the network conditions.

[prusnak]

So the answer to your question is: it varies by the network conditions.

That's really not helpful in deciding whether it's worth implementing this or not.

Anyways, the Ethereum community is welcome to contribute a patch via a pull request. We can't afford to spend our resources to development of this feature, but we'll gladly review the change.

[timbeiko]

If anyone is interested in adding this to Trezor and funds are the blocker in doing so, please ping me (tim@ethereum.org) and I can help set up a bounty for it.

[FrederikBolding]

I'm gonna take a look at the code to see how difficult it would be to implement this. Will report back with any progress.

EDIT: I have started hacking something together here: https://github.com/FrederikBolding/trezor-firmware/tree/eth-eip-1559
Will see how it goes 😄

EDIT2: Have successfully signed and sent a tx - now need to clean it up 😄

[FrederikBolding]

After a bit of back and forth over the weekend (and some long nights 😴) it seems that I have a working version of the Trezor firmware that supports EIP 1559. I have opened a pull request (#1653) and we will see what the Trezor reviewers say!

[scooper4711]

This is closed - does this mean it works in both Trezor products you actively sell? Or is the Model 1 considered abandoned and won't be updated?

[monomesa]

Waiting for the trezor one. :(

[prusnak]

@scooper4711 @monomesa we are investigating EIP-1559 for Trezor Model One in #1834