Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coinmarket - Allow buy without connected Trezor device #14310

Closed
adderpositive opened this issue Sep 12, 2024 · 8 comments · Fixed by #14320
Closed

Coinmarket - Allow buy without connected Trezor device #14310

adderpositive opened this issue Sep 12, 2024 · 8 comments · Fixed by #14320
Assignees
@adderpositive
Labels
feature Product related issue visible for end user +Invity Related to Invity project QA OK Issue passed QA without any blocker

Comments

@adderpositive
Copy link
Contributor

adderpositive commented Sep 12, 2024 •
edited
Loading

Issue

When a user gets to the second step in the Buy flow where they select a specific address to receive crypto and the Trezor is disconnected, Suite only allows to Show an unverified address and copy it so the user is stuck.
obrazek

Solution

Instead of “Show unverified address” in this dialog show “Proceed with unverified address” button, close the dialog, and allow a user to proceed to the partner’s checkout.

obrazek
@adderpositive adderpositive added feature Product related issue visible for end user +Invity Related to Invity project labels Sep 12, 2024
@adderpositive adderpositive self-assigned this Sep 12, 2024
@github-project-automation github-project-automation bot moved this to 🎯 To do in Issues Suite Sep 12, 2024
@adderpositive adderpositive mentioned this issue Sep 12, 2024
Merged
@Hermez-cz
Copy link

Please update the modal component to this warning one: https://www.figma.com/design/dYIRTk1qVcKsrJDqOzZ7SG/Modals?node-id=4037-2006&t=61v4fJb4LWtWq6cX-1

image

@adderpositive
Copy link
Contributor Author

@Hermez-cz It should be fine (used a new design for the modal), only without an Icon.

obrazek

@Hermez-cz
Copy link

@adderpositive If it's a warning modal (yellow), it should have the icon and the layout as linked above.

The used layout is intended just to plain informative purposes.

@github-project-automation github-project-automation bot moved this from 🎯 To do to 🤝 Needs QA in Issues Suite Sep 27, 2024
@STew790
Copy link
Contributor

STew790 commented Oct 1, 2024

QA OK
There is "Continue..." instead of "Proceed.." but I assume that is ok.
image

Info:

  • Suite version: desktop 24.10.0 (ac53d35)
  • Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuiteDev/24.10.0 Chrome/126.0.6478.234 Electron/31.6.0 Safari/537.36
  • OS: Linux x86_64
  • Screen: 1920x1080
  • Device: Trezor T2T1 2.8.1 regular (revision 632b9561559b7ab6824bb7eeac072874e07b7b82)
  • Transport: BridgeTransport 2.0.33

@STew790 STew790 moved this from 🤝 Needs QA to ✅ Approved in Issues Suite Oct 1, 2024
@STew790 STew790 added the QA OK Issue passed QA without any blocker label Oct 1, 2024
@adderpositive
Copy link
Contributor Author

No, it's not correct. There should be Proceed

@STew790
Copy link
Contributor

STew790 commented Oct 1, 2024

QA NOK
Ok, I stand corrected, sorry. Then it is not OK.

@STew790 STew790 added QA NOK Issue doesn't pass the QA and some changes are needed. and removed QA OK Issue passed QA without any blocker labels Oct 1, 2024
@STew790 STew790 moved this from ✅ Approved to 🎯 To do in Issues Suite Oct 1, 2024
@adderpositive
Copy link
Contributor Author

Should be resolved here #14644

@adderpositive adderpositive moved this from 🎯 To do to 🤝 Needs QA in Issues Suite Oct 1, 2024
@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Issues Suite Oct 1, 2024
@bosomt
Copy link
Contributor

bosomt commented Oct 1, 2024

QA OK

Proceed with unverified address needs to be translated.

Image

Info:

  • Suite version: desktop 24.10.0 (2187dc0)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuiteDev/24.10.0 Chrome/126.0.6478.234 Electron/31.6.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T2T1 2.8.1 regular (revision 632b9561559b7ab6824bb7eeac072874e07b7b82)
  • Transport: BridgeTransport 3.0.0-bundled.24.10.0

@STew790 STew790 added QA OK Issue passed QA without any blocker and removed QA NOK Issue doesn't pass the QA and some changes are needed. labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adderpositive adderpositive

Labels
feature Product related issue visible for end user +Invity Related to Invity project QA OK Issue passed QA without any blocker
Projects
Issues Suite
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(coinmarket): possibility to proceed with unverified address trezor/trezor-suite
4 participants
@adderpositive @bosomt @STew790 @Hermez-cz