fix(coinmarket): fix send all amount mismatch with created trade #16052
+0
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreeWall
added
bug
adderpositive
approved these changes
Dec 19, 2024
FreeWall
force-pushed
the
fix/coinmarket-send-all-amount-mismatch
branch
from
b860c11 to
d3bbde0
Compare
tomasklim
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With use of "all" button of send amount in sell/swap form, the final amount during signing transaction is slightly different from the created trade's amount (not sure why, maybe transaction size is different).
Related Issue
Resolve #16046