Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MetaMask tests run with Trezor Connect v9 #5776

Closed
sime opened this issue Jul 13, 2022 · 1 comment
Closed

Make MetaMask tests run with Trezor Connect v9 #5776

sime opened this issue Jul 13, 2022 · 1 comment
Labels
bug Something isn't working as expected connect Connect API related (ie. fee calculation)

Comments

@sime
Copy link
Contributor

sime commented Jul 13, 2022

Swapping in Connect v9 for v8 throws an unexpected error in unit tests:

Error: TrezorConnect has been already initialized
https://github.com/MetaMask/eth-trezor-keyring/runs/7038556243?check_suite_focus=true#step:10:15

MetaMask/eth-trezor-keyring#132

@sime sime added the connect Connect API related (ie. fee calculation) label Jul 13, 2022
@hynek-jina hynek-jina added bug Something isn't working as expected Team Connect labels Jul 13, 2022
@mroz22
Copy link
Contributor

mroz22 commented Jul 13, 2022

Should be fixed here MetaMask/eth-trezor-keyring#133

@mroz22 mroz22 moved this from 🎯 To do to ✅ Approved in Suite Desktop Jul 18, 2022
Repository owner moved this from ✅ Approved to 🤝 Needs QA in Suite Desktop Sep 8, 2022
@hynek-jina hynek-jina moved this from 🤝 Needs QA to ✅ Approved in Suite Desktop Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected connect Connect API related (ie. fee calculation)
Projects
Archived in project
Development

No branches or pull requests

3 participants