-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grav 1.7RC with Flex Pages and Grav 1.6.21 unable to setup Git Sync #159
Comments
Thanks, we'll take a look! /cc @mahagr |
@w00fz This is because of the plugin has strict mode turned on and there was a bug preventing blueprint strict mode from working. Not sure why there's extra variable in the configuration, is it set in the form? |
Looks like I cannot change the title, but this would happen also with the old pages. :) |
Hi @w00fz , I've just had someone contact me about this error now happening with the latest Stable Grav release, and I can confirm as I just did a test install myself. If I can be of any more help please let me know. |
This is the fix from Grav 1.6.20 causing the issue: The fix is correct, so the bug is in the plugin configuration. |
Can you make gitsync right then 🙂? |
For now, I reverted the |
Thanks @mahagr |
I'm going to reopen this as it's not fully solved in Grav 1.7. In fact, I was not able to reproduce the issue; saving worked just fine for me even with the strict limitations. I'm not sure why there's |
@paulhibbitts do you have that text_var field in the gitsync plugin blueprint or saved in the user config somewhere? It is a bit odd it fails on that field. |
Hi @w00fz I don't think I added anything on my end... I will try to setup an online test version going that you can take a look at too. |
@w00fz , I've got a test site going online with the issue - will connect on Discord with login info etc. |
Thanks to the detective work of @w00fz I tracked down this issue to a deprecated item in the plugin config file - solved by removing this item (which was caught due to the improvements for strict validation). |
Hi @w00fz , I've started doing more testing with 1.7 Flex Pages and I think I've come across an issue:
The wizard when completed will re-appear, and you will see the following error message:
If I can be of any help re: testing more info etc. please let me know.
BTW, it seems that if you install Git Sync on 1.7RC6, and THEN turn on Flex Pages front-end things work fine (though sometimes there might be up to a minute before change is reflected on site).
Thanks very much,
Paul
The text was updated successfully, but these errors were encountered: