Ifpack2: Test failure in MPI=off build

[cgcgcg]

@trilinos/ifpack2 @tmranse

Bug Report

The unit test for the newly added MDF preconditioner is failing when Trilinos is built without MPI:
https://testing.sandia.gov/cdash/test/161038709

This build configuration is not super important, but this should probably be fixed in the next PR for MDF.

[github-actions]

Automatic mention of the @trilinos/ifpack2 team

[jhux2]

fyi @tmranse

[tmranse]

@jhux2 Got it, was planning on removing the std::complex checks once we get a new integration of Kokkos Kernels and tacking this on then but can fix it sooner if you prefer.

[jhux2]

@tmranse I think it's fine to wait for the new integration, thanks.

[cgcgcg]

@tmranse Would it be possible to also fix issues with Scalar=float in the next PR? Thanks!
https://testing.sandia.gov/cdash/test/161828371
https://testing.sandia.gov/cdash/test/161828372

[cgcgcg]

FYI, there are also valgrind warnings about MDF:
https://testing.sandia.gov/cdash/viewDynamicAnalysisFile.php?id=519585

[srajama1]

@lucbv : FYI

[cgcgcg]

@tmranse The recent PR changed the failure mode of the MDF unit tests:
https://testing.sandia.gov/cdash/test/165207397
The valgrind warnings are still there:
https://testing.sandia.gov/cdash/viewDynamicAnalysisFile.php?id=522065

[tmranse]

@tmranse The recent PR changed the failure mode of the MDF unit tests

@cgcgcg I'm a little confused by this since the only place Ifpack2_UnitTestMDF.cpp calls AdditiveSchwarz is wrapped in the same ifdef guards as that throw. A lot of the line numbers the tests are reporting also are just pointing to empty lines. Is there some other branch I should be looking at for these tests? Can you point me to a reference to recreate them if so?

[cgcgcg]

Hm, good catch about the line numbers. The build seems to be stuck on an old commit. Lemme investigate.

[cgcgcg]

@tmranse Looks like the unit test failure is indeed fixed! Sorry about that. Valgrind on the other hand is still complaining:
https://testing.sandia.gov/cdash/viewDynamicAnalysisFile.php?id=522152

[GrahamBenHarper]

is this fixed?

[cgcgcg]

@GrahamBenHarper You can check the valgrind report here: https://testing.sandia.gov/cdash/viewDynamicAnalysis.php?buildid=11633396

[GrahamBenHarper]

Oh I understand now. We're waiting on a kokkos-kernels promotion to cover this. Sorry about that