-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MueLu: Linker errors from missing explicit template instations for Kokkos::CudaUVMSpace
#12846
Comments
Automatic mention of the @trilinos/muelu team |
@trilinos/muelu @MalachiTimothyPhillips Is this with a recent integration of Trilinos? |
Correct -- this isn't currently preventing Sierra from building, but we are looking to do an integration soon. The last integration we did was November 9, 2013. |
@MalachiTimothyPhillips Can you share a configure script? |
These are the configure flags passed to Note the full spack paths for 3rd party library/include dirs is abbreviated |
@MalachiTimothyPhillips Could you try with these flags?
See #12622. |
No luck. I've generated a smaller reproducer that is accessible here: https://github.com/MalachiTimothyPhillips/trilinos-issue-12846. edit: After taking a closer look, it looks like the linker errors in the stub above (and my example) stem from trying to use e.g.:
The cmake configuration indicates that the only support global ordinal type is
I am not sure where/why the I should also note we are not seeing these linker errors on GCC/Clang, for example. |
Setting:
I see the following CMake configure output:
That has to be wrong, right? I think this is why I'm hitting the linker errors. |
@MalachiTimothyPhillips I'm not sure if this is your issue, but the way the variables work is
So setting |
Right -- why is MueLu configured with Trilinos/packages/muelu/CMakeLists.txt Line 242 in 88b2d6f
|
Oh, no I see that. 👀 |
Can you try to change from: Trilinos/packages/muelu/CMakeLists.txt Lines 241 to 242 in 88b2d6f
to
? Cause that looks fishy. |
NVM, I think something is quite wrong in our CMake for long. Well, actually, it might just be weird. |
Sure! Trilinos/packages/muelu/CMakeLists.txt Line 283 in 88b2d6f
Previous Trilinos versions (e.g., de68716, which is our current version in Sierra) had the same configuration. I'm wondering if there's some change in ETI handling for the edit: I guess another complication is the fact that Epetra seems to require |
Nope, only that spot. Yeah, I'm also not sure how this could have worked before. edit: Yes, if you want Epetra+Tpetra you need int-int. |
Good news -- that seems to have fixed the linker errors on our end! See: #12881. Thank you for your help! |
Marking as closed now that #12881 has been merged. |
Bug Report
@muelu
@jhux2
Description
I am running into some linker issues in a
nvidia
Sierra spack build of Trilinos.It looks as if MueLu is missing explicit template instantiations for
Kokkos::CudaUVMSpace
(see linker output below).I will attempt to resolve the issue on my end, but I am not familiar with how MueLu handles the explicit template instantiations.
The text was updated successfully, but these errors were encountered: