Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tpetra: Track CrsGraph/CrsMatrix refactoring for UVM removal #8930

Closed
5 of 15 tasks
kddevin opened this issue Mar 29, 2021 · 0 comments
Closed
5 of 15 tasks

Tpetra: Track CrsGraph/CrsMatrix refactoring for UVM removal #8930

kddevin opened this issue Mar 29, 2021 · 0 comments

Comments

@kddevin
Copy link
Contributor

kddevin commented Mar 29, 2021

Tracking UVM-requirement removal from CrsGraph and CrsMatrix

@trilinos/tpetra

Code is in branch trilinos/tpetraCrsRefactor

This issue tracks progress on removal of UVM from Tpetra's CrsGraph and CrsMatrix.

For information on Tpetra's MultiVector and BlockMultivector, see #8591
Other related (and perhaps outdated) issues include #8426, #8345, #8305, #8286, #8209, #8151

Currently failing Tpetra tests with UVM=OFF and DEPRECATED_CODE=ON

BlockCrsMatrix not yet addressed:

  • 29:TpetraCore_BlockCrsMatrix_MPI_4
  • 268:TpetraCore_BlockCrsPerfTest_MPI_4

Under investigation

  • 38:TpetraCore_iallreduce_MPI_4
  • 42:TpetraCore_idot_MPI_4

Need merge of kokkos/kokkos-kernels#917 into Trilinos:

  • 81:TpetraCore_CrsMatrix_UnitTests_Swap_MPI_2
  • 120:TpetraCore_FECrsMatrix_UnitTests_MPI_4
  • 211:TpetraCore_MatrixMatrix_UnitTests_MPI_4

Need refactor of FEMAssembly example; should not impact Tpetra use by solvers:

  • 263:TpetraCore_FEMAssembly_InsertGlobalIndicesFESP_MPI_4
  • 264:TpetraCore_FEMAssembly_InsertGlobalIndicesFESPKokkos_MPI_4
  • 265:TpetraCore_FEMAssembly_TotalElementLoopSP_MPI_4
  • 266:TpetraCore_FEMAssembly_TotalElementLoopSPKokkos_MPI_4

Still to do:

  • Builds with DEPRECATED_CODE=OFF
  • Handling of complex (std::complex vs Kokkos::complex)
  • UVM=ON testing of Trilinos stack
  • Clean up "KDDKDD UVM" notes still in code (esp wrapping in ArrayView in Tpetra_CrsMatrix_def.hpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant