Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

fix: Replace @material/dom with SSR compatible code #2106

Merged
merged 8 commits into from
Feb 25, 2020
Merged

Conversation

trimox
Copy link
Owner

@trimox trimox commented Feb 18, 2020

closes #2031

@trimox trimox added this to the v5.0.4 milestone Feb 18, 2020
@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #2106 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2106      +/-   ##
==========================================
- Coverage   90.67%   90.65%   -0.03%     
==========================================
  Files         100      100              
  Lines        4344     4344              
  Branches      559      559              
==========================================
- Hits         3939     3938       -1     
- Misses        214      215       +1     
  Partials      191      191
Impacted Files Coverage Δ
packages/notched-outline/notched-outline.ts 100% <ø> (ø) ⬆️
packages/dialog/dialog.component.ts 86.66% <0%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e50f078...25ee84a. Read the comment docs.

@trimox trimox modified the milestones: v5.0.4, v5.0.5 Feb 19, 2020
@trimox trimox changed the title fix: SSR runtime failure fix: SSR runtime errors using ponyfill Feb 19, 2020
@trimox
Copy link
Owner Author

trimox commented Feb 20, 2020

Requesting help from community for SSR compatibility testing of the PR branch. If you can spare some time, I'd appreciate it!

@trimox trimox changed the title fix: SSR runtime errors using ponyfill fix: Replace @material/dom with SSR compatible code Feb 25, 2020
@trimox trimox merged commit 27dad44 into master Feb 25, 2020
@trimox trimox deleted the fix/ssr-dom branch February 25, 2020 11:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular SSR fails during runtime for @material/dom.
1 participant