Support and test against newer Go versions #2
Comments
|
Am not sure if you have tried testing, but there is issue with running test code since 1.13+ |
|
Issue here suggests a workaround and it does work if i set the following code inside var _ = func() bool {
testing.Init()
return true
}()here is the result with go 1.14 test after pulling repoRunning tool: /usr/local/go/bin/go test -timeout 30s -coverprofile=/var/folders/5d/mbcxtdy13sj4vcwprc7pphpc0000gn/T/vscode-goPEJZLj/go-code-cover=== RUN TestIntegrationEnabled |
|
@losipiuk thoughts? |
|
IIUC the problem comes from the fact that we are calling I think the only option is to explicitly call |
|
Tests worked well for 1.14 :) test after adding testing.Init()jyoo94: ~/work/jyoo94/lago-presto-go-client/integration_tests $ ./run.sh waiting for presto... waiting for presto... presto server running === RUN TestIntegrationEnabled --- PASS: TestIntegrationEnabled (0.00s) === RUN TestIntegrationSelectQueryIterator --- PASS: TestIntegrationSelectQueryIterator (0.35s) === RUN TestIntegrationSelectQueryNoResult --- PASS: TestIntegrationSelectQueryNoResult (0.10s) === RUN TestIntegrationSelectFailedQuery --- PASS: TestIntegrationSelectFailedQuery (0.02s) === RUN TestIntegrationSelectTpch1000 --- PASS: TestIntegrationSelectTpch1000 (2.63s) === RUN TestIntegrationSelectCancelQuery --- PASS: TestIntegrationSelectCancelQuery (0.20s) === RUN TestIntegrationSessionProperties --- PASS: TestIntegrationSessionProperties (1.07s) === RUN TestIntegrationTypeConversion --- PASS: TestIntegrationTypeConversion (0.71s) === RUN TestIntegrationNoResults --- PASS: TestIntegrationNoResults (0.07s) === RUN TestIntegrationQueryParametersSelect === RUN TestIntegrationQueryParametersSelect/valid_string_as_varchar === RUN TestIntegrationQueryParametersSelect/valid_int_as_bigint === RUN TestIntegrationQueryParametersSelect/invalid_string_as_bigint === RUN TestIntegrationQueryParametersSelect/valid_string_as_date --- PASS: TestIntegrationQueryParametersSelect (0.95s) --- PASS: TestIntegrationQueryParametersSelect/valid_string_as_varchar (0.30s) --- PASS: TestIntegrationQueryParametersSelect/valid_int_as_bigint (0.61s) --- PASS: TestIntegrationQueryParametersSelect/invalid_string_as_bigint (0.02s) --- PASS: TestIntegrationQueryParametersSelect/valid_string_as_date (0.02s) === RUN TestIntegrationTLS --- PASS: TestIntegrationTLS (0.08s) === RUN TestIntegrationInsecureTLS --- PASS: TestIntegrationInsecureTLS (0.09s) === RUN TestConfig --- PASS: TestConfig (0.00s) === RUN TestConfigSSLCertPath --- PASS: TestConfigSSLCertPath (0.00s) === RUN TestConfigWithoutSSLCertPath --- PASS: TestConfigWithoutSSLCertPath (0.00s) === RUN TestKerberosConfig --- PASS: TestKerberosConfig (0.00s) === RUN TestInvalidKerberosConfig --- PASS: TestInvalidKerberosConfig (0.00s) === RUN TestConfigWithMalformedURL --- PASS: TestConfigWithMalformedURL (0.00s) === RUN TestConnErrorDSN === RUN TestConnErrorDSN/malformed === RUN TestConnErrorDSN/unknown_client --- PASS: TestConnErrorDSN (0.00s) --- PASS: TestConnErrorDSN/malformed (0.00s) --- PASS: TestConnErrorDSN/unknown_client (0.00s) === RUN TestRegisterCustomClientReserved === RUN TestRegisterCustomClientReserved/true === RUN TestRegisterCustomClientReserved/false --- PASS: TestRegisterCustomClientReserved (0.00s) --- PASS: TestRegisterCustomClientReserved/true (0.00s) --- PASS: TestRegisterCustomClientReserved/false (0.00s) === RUN TestRoundTripRetryQueryError --- PASS: TestRoundTripRetryQueryError (0.10s) === RUN TestRoundTripCancellation --- PASS: TestRoundTripCancellation (0.05s) === RUN TestAuthFailure --- PASS: TestAuthFailure (0.00s) === RUN TestQueryCancellation --- PASS: TestQueryCancellation (0.00s) === RUN TestQueryFailure --- PASS: TestQueryFailure (0.00s) === RUN TestSSLCertPath --- PASS: TestSSLCertPath (0.00s) === RUN TestWithoutSSLCertPath --- PASS: TestWithoutSSLCertPath (0.00s) === RUN TestUnsupportedExec --- PASS: TestUnsupportedExec (0.00s) === RUN TestUnsupportedTransaction --- PASS: TestUnsupportedTransaction (0.00s) === RUN TestTypeConversion === RUN TestTypeConversion/boolean:nil === RUN TestTypeConversion/boolean:bogus === RUN TestTypeConversion/boolean:sample === RUN TestTypeConversion/varchar(1):nil === RUN TestTypeConversion/varchar(1):bogus === RUN TestTypeConversion/varchar(1):sample === RUN TestTypeConversion/bigint:nil === RUN TestTypeConversion/bigint:bogus === RUN TestTypeConversion/bigint:sample === RUN TestTypeConversion/double:nil === RUN TestTypeConversion/double:bogus === RUN TestTypeConversion/double:sample === RUN TestTypeConversion/date:nil === RUN TestTypeConversion/date:bogus === RUN TestTypeConversion/date:sample === RUN TestTypeConversion/time:nil === RUN TestTypeConversion/time:bogus === RUN TestTypeConversion/time:sample === RUN TestTypeConversion/time_with_time_zone:nil === RUN TestTypeConversion/time_with_time_zone:bogus === RUN TestTypeConversion/time_with_time_zone:sample === RUN TestTypeConversion/timestamp:nil === RUN TestTypeConversion/timestamp:bogus === RUN TestTypeConversion/timestamp:sample === RUN TestTypeConversion/timestamp_with_time_zone:nil === RUN TestTypeConversion/timestamp_with_time_zone:bogus === RUN TestTypeConversion/timestamp_with_time_zone:sample === RUN TestTypeConversion/map:nil === RUN TestTypeConversion/map:bogus === RUN TestTypeConversion/map:sample === RUN TestTypeConversion/array:nil === RUN TestTypeConversion/array:bogus === RUN TestTypeConversion/array:sample --- PASS: TestTypeConversion (0.00s) --- PASS: TestTypeConversion/boolean:nil (0.00s) --- PASS: TestTypeConversion/boolean:bogus (0.00s) --- PASS: TestTypeConversion/boolean:sample (0.00s) --- PASS: TestTypeConversion/varchar(1):nil (0.00s) --- PASS: TestTypeConversion/varchar(1):bogus (0.00s) --- PASS: TestTypeConversion/varchar(1):sample (0.00s) --- PASS: TestTypeConversion/bigint:nil (0.00s) --- PASS: TestTypeConversion/bigint:bogus (0.00s) --- PASS: TestTypeConversion/bigint:sample (0.00s) --- PASS: TestTypeConversion/double:nil (0.00s) --- PASS: TestTypeConversion/double:bogus (0.00s) --- PASS: TestTypeConversion/double:sample (0.00s) --- PASS: TestTypeConversion/date:nil (0.00s) --- PASS: TestTypeConversion/date:bogus (0.00s) --- PASS: TestTypeConversion/date:sample (0.00s) --- PASS: TestTypeConversion/time:nil (0.00s) --- PASS: TestTypeConversion/time:bogus (0.00s) --- PASS: TestTypeConversion/time:sample (0.00s) --- PASS: TestTypeConversion/time_with_time_zone:nil (0.00s) --- PASS: TestTypeConversion/time_with_time_zone:bogus (0.00s) --- PASS: TestTypeConversion/time_with_time_zone:sample (0.00s) --- PASS: TestTypeConversion/timestamp:nil (0.00s) --- PASS: TestTypeConversion/timestamp:bogus (0.00s) --- PASS: TestTypeConversion/timestamp:sample (0.00s) --- PASS: TestTypeConversion/timestamp_with_time_zone:nil (0.00s) --- PASS: TestTypeConversion/timestamp_with_time_zone:bogus (0.00s) --- PASS: TestTypeConversion/timestamp_with_time_zone:sample (0.00s) --- PASS: TestTypeConversion/map:nil (0.00s) --- PASS: TestTypeConversion/map:bogus (0.00s) --- PASS: TestTypeConversion/map:sample (0.00s) --- PASS: TestTypeConversion/array:nil (0.00s) --- PASS: TestTypeConversion/array:bogus (0.00s) --- PASS: TestTypeConversion/array:sample (0.00s) === RUN TestSliceTypeConversion === RUN TestSliceTypeConversion/[]bool:nil === RUN TestSliceTypeConversion/[]bool:bogus === RUN TestSliceTypeConversion/[]bool:sample === RUN TestSliceTypeConversion/[]string:nil === RUN TestSliceTypeConversion/[]string:bogus === RUN TestSliceTypeConversion/[]string:sample === RUN TestSliceTypeConversion/[]int64:nil === RUN TestSliceTypeConversion/[]int64:bogus === RUN TestSliceTypeConversion/[]int64:sample === RUN TestSliceTypeConversion/[]float64:nil === RUN TestSliceTypeConversion/[]float64:bogus === RUN TestSliceTypeConversion/[]float64:sample === RUN TestSliceTypeConversion/[]time.Time:nil === RUN TestSliceTypeConversion/[]time.Time:bogus === RUN TestSliceTypeConversion/[]time.Time:sample === RUN TestSliceTypeConversion/[]map[string]interface{}:nil === RUN TestSliceTypeConversion/[]map[string]interface{}:bogus === RUN TestSliceTypeConversion/[]map[string]interface{}:sample --- PASS: TestSliceTypeConversion (0.00s) --- PASS: TestSliceTypeConversion/[]bool:nil (0.00s) --- PASS: TestSliceTypeConversion/[]bool:bogus (0.00s) --- PASS: TestSliceTypeConversion/[]bool:sample (0.00s) --- PASS: TestSliceTypeConversion/[]string:nil (0.00s) --- PASS: TestSliceTypeConversion/[]string:bogus (0.00s) --- PASS: TestSliceTypeConversion/[]string:sample (0.00s) --- PASS: TestSliceTypeConversion/[]int64:nil (0.00s) --- PASS: TestSliceTypeConversion/[]int64:bogus (0.00s) --- PASS: TestSliceTypeConversion/[]int64:sample (0.00s) --- PASS: TestSliceTypeConversion/[]float64:nil (0.00s) --- PASS: TestSliceTypeConversion/[]float64:bogus (0.00s) --- PASS: TestSliceTypeConversion/[]float64:sample (0.00s) --- PASS: TestSliceTypeConversion/[]time.Time:nil (0.00s) --- PASS: TestSliceTypeConversion/[]time.Time:bogus (0.00s) --- PASS: TestSliceTypeConversion/[]time.Time:sample (0.00s) --- PASS: TestSliceTypeConversion/[]map[string]interface{}:nil (0.00s) --- PASS: TestSliceTypeConversion/[]map[string]interface{}:bogus (0.00s) --- PASS: TestSliceTypeConversion/[]map[string]interface{}:sample (0.00s) === RUN TestSlice2TypeConversion === RUN TestSlice2TypeConversion/[][]bool:nil === RUN TestSlice2TypeConversion/[][]bool:bogus === RUN TestSlice2TypeConversion/[][]bool:sample === RUN TestSlice2TypeConversion/[][]string:nil === RUN TestSlice2TypeConversion/[][]string:bogus === RUN TestSlice2TypeConversion/[][]string:sample === RUN TestSlice2TypeConversion/[][]int64:nil === RUN TestSlice2TypeConversion/[][]int64:bogus === RUN TestSlice2TypeConversion/[][]int64:sample === RUN TestSlice2TypeConversion/[][]float64:nil === RUN TestSlice2TypeConversion/[][]float64:bogus === RUN TestSlice2TypeConversion/[][]float64:sample === RUN TestSlice2TypeConversion/[][]time.Time:nil === RUN TestSlice2TypeConversion/[][]time.Time:bogus === RUN TestSlice2TypeConversion/[][]time.Time:sample === RUN TestSlice2TypeConversion/[][]map[string]interface{}:nil === RUN TestSlice2TypeConversion/[][]map[string]interface{}:bogus === RUN TestSlice2TypeConversion/[][]map[string]interface{}:sample --- PASS: TestSlice2TypeConversion (0.00s) --- PASS: TestSlice2TypeConversion/[][]bool:nil (0.00s) --- PASS: TestSlice2TypeConversion/[][]bool:bogus (0.00s) --- PASS: TestSlice2TypeConversion/[][]bool:sample (0.00s) --- PASS: TestSlice2TypeConversion/[][]string:nil (0.00s) --- PASS: TestSlice2TypeConversion/[][]string:bogus (0.00s) --- PASS: TestSlice2TypeConversion/[][]string:sample (0.00s) --- PASS: TestSlice2TypeConversion/[][]int64:nil (0.00s) --- PASS: TestSlice2TypeConversion/[][]int64:bogus (0.00s) --- PASS: TestSlice2TypeConversion/[][]int64:sample (0.00s) --- PASS: TestSlice2TypeConversion/[][]float64:nil (0.00s) --- PASS: TestSlice2TypeConversion/[][]float64:bogus (0.00s) --- PASS: TestSlice2TypeConversion/[][]float64:sample (0.00s) --- PASS: TestSlice2TypeConversion/[][]time.Time:nil (0.00s) --- PASS: TestSlice2TypeConversion/[][]time.Time:bogus (0.00s) --- PASS: TestSlice2TypeConversion/[][]time.Time:sample (0.00s) --- PASS: TestSlice2TypeConversion/[][]map[string]interface{}:nil (0.00s) --- PASS: TestSlice2TypeConversion/[][]map[string]interface{}:bogus (0.00s) --- PASS: TestSlice2TypeConversion/[][]map[string]interface{}:sample (0.00s) === RUN TestSlice3TypeConversion === RUN TestSlice3TypeConversion/[][][]bool:nil === RUN TestSlice3TypeConversion/[][][]bool:bogus === RUN TestSlice3TypeConversion/[][][]bool:sample === RUN TestSlice3TypeConversion/[][][]string:nil === RUN TestSlice3TypeConversion/[][][]string:bogus === RUN TestSlice3TypeConversion/[][][]string:sample === RUN TestSlice3TypeConversion/[][][]int64:nil === RUN TestSlice3TypeConversion/[][][]int64:bogus === RUN TestSlice3TypeConversion/[][][]int64:sample === RUN TestSlice3TypeConversion/[][][]float64:nil === RUN TestSlice3TypeConversion/[][][]float64:bogus === RUN TestSlice3TypeConversion/[][][]float64:sample === RUN TestSlice3TypeConversion/[][][]time.Time:nil === RUN TestSlice3TypeConversion/[][][]time.Time:bogus === RUN TestSlice3TypeConversion/[][][]time.Time:sample === RUN TestSlice3TypeConversion/[][][]map[string]interface{}:nil === RUN TestSlice3TypeConversion/[][][]map[string]interface{}:bogus === RUN TestSlice3TypeConversion/[][][]map[string]interface{}:sample --- PASS: TestSlice3TypeConversion (0.00s) --- PASS: TestSlice3TypeConversion/[][][]bool:nil (0.00s) --- PASS: TestSlice3TypeConversion/[][][]bool:bogus (0.00s) --- PASS: TestSlice3TypeConversion/[][][]bool:sample (0.00s) --- PASS: TestSlice3TypeConversion/[][][]string:nil (0.00s) --- PASS: TestSlice3TypeConversion/[][][]string:bogus (0.00s) --- PASS: TestSlice3TypeConversion/[][][]string:sample (0.00s) --- PASS: TestSlice3TypeConversion/[][][]int64:nil (0.00s) --- PASS: TestSlice3TypeConversion/[][][]int64:bogus (0.00s) --- PASS: TestSlice3TypeConversion/[][][]int64:sample (0.00s) --- PASS: TestSlice3TypeConversion/[][][]float64:nil (0.00s) --- PASS: TestSlice3TypeConversion/[][][]float64:bogus (0.00s) --- PASS: TestSlice3TypeConversion/[][][]float64:sample (0.00s) --- PASS: TestSlice3TypeConversion/[][][]time.Time:nil (0.00s) --- PASS: TestSlice3TypeConversion/[][][]time.Time:bogus (0.00s) --- PASS: TestSlice3TypeConversion/[][][]time.Time:sample (0.00s) --- PASS: TestSlice3TypeConversion/[][][]map[string]interface{}:nil (0.00s) --- PASS: TestSlice3TypeConversion/[][][]map[string]interface{}:bogus (0.00s) --- PASS: TestSlice3TypeConversion/[][][]map[string]interface{}:sample (0.00s) === RUN TestSerial === RUN TestSerial/basic_string === RUN TestSerial/single_quoted_string === RUN TestSerial/double_quoted_string === RUN TestSerial/int8 === RUN TestSerial/int16 === RUN TestSerial/int32 === RUN TestSerial/int === RUN TestSerial/int64 === RUN TestSerial/uint8 === RUN TestSerial/uint16 === RUN TestSerial/uint32 === RUN TestSerial/uint === RUN TestSerial/uint64 === RUN TestSerial/byte === RUN TestSerial/valid_Numeric === RUN TestSerial/invalid_Numeric === RUN TestSerial/bool_true === RUN TestSerial/bool_false === RUN TestSerial/nil === RUN TestSerial/slice_typed_nil === RUN TestSerial/valid_slice === RUN TestSerial/valid_empty === RUN TestSerial/invalid_slice_contents --- PASS: TestSerial (0.00s) --- PASS: TestSerial/basic_string (0.00s) --- PASS: TestSerial/single_quoted_string (0.00s) --- PASS: TestSerial/double_quoted_string (0.00s) --- PASS: TestSerial/int8 (0.00s) --- PASS: TestSerial/int16 (0.00s) --- PASS: TestSerial/int32 (0.00s) --- PASS: TestSerial/int (0.00s) --- PASS: TestSerial/int64 (0.00s) --- PASS: TestSerial/uint8 (0.00s) --- PASS: TestSerial/uint16 (0.00s) --- PASS: TestSerial/uint32 (0.00s) --- PASS: TestSerial/uint (0.00s) --- PASS: TestSerial/uint64 (0.00s) --- PASS: TestSerial/byte (0.00s) --- PASS: TestSerial/valid_Numeric (0.00s) --- PASS: TestSerial/invalid_Numeric (0.00s) --- PASS: TestSerial/bool_true (0.00s) --- PASS: TestSerial/bool_false (0.00s) --- PASS: TestSerial/nil (0.00s) --- PASS: TestSerial/slice_typed_nil (0.00s) --- PASS: TestSerial/valid_slice (0.00s) --- PASS: TestSerial/valid_empty (0.00s) --- PASS: TestSerial/invalid_slice_contents (0.00s) PASS coverage: 89.4% of statements ok github.com/prestosql/presto-go-client/presto 6.440s coverage: 89.4% of statements 99c466488f6d73813ea89497f64e210b7ceb5284978dff06d31f12ce0ab5395e |
We should update
.travis.ymlto test against newer Go versions (and make any required code changes to allow this):The text was updated successfully, but these errors were encountered: