Handle secondary TLS port 8443 as https by default

Author: Spikhalskiy

tests/unit/test_dbapi.py

@@ -325,6 +325,7 @@ def test_description_is_none_when_cursor_is_not_executed():
         ("http://mytrinoserver.domain:9999", None, None, constants.HTTP),
         # Infer from port
         ("mytrinoserver.domain", constants.DEFAULT_TLS_PORT, None, constants.HTTPS),
+        ("mytrinoserver.domain", constants.SECONDARY_TLS_PORT, None, constants.HTTPS),
         ("mytrinoserver.domain", constants.DEFAULT_PORT, None, constants.HTTP),
         # http_scheme parameter has higher precedence than port parameter
         ("mytrinoserver.domain", constants.DEFAULT_TLS_PORT, constants.HTTP, constants.HTTP),

trino/constants.py

@@ -14,6 +14,7 @@
 
 DEFAULT_PORT = 8080
 DEFAULT_TLS_PORT = 443
+SECONDARY_TLS_PORT = 8443
 DEFAULT_SOURCE = "trino-python-client"
 DEFAULT_CATALOG: Optional[str] = None
 DEFAULT_SCHEMA: Optional[str] = None

trino/dbapi.py

@@ -208,7 +208,7 @@ def __init__(
             self.http_scheme = parsed_host.scheme
         elif http_scheme:
             self.http_scheme = http_scheme
-        elif port == constants.DEFAULT_TLS_PORT:
+        elif port in (constants.DEFAULT_TLS_PORT, constants.SECONDARY_TLS_PORT):
             self.http_scheme = constants.HTTPS
         elif port == constants.DEFAULT_PORT:
             self.http_scheme = constants.HTTP