Accept shorthand format for system roles #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdesmet
reviewed
Mar 2, 2023
trino/client.py
Outdated
| def _format_roles(self, roles): | ||
| def _format_roles(self, role, roles): | ||
| if role and roles: | ||
| raise ValueError("specify either 'role' or 'roles' parameter, but not both") |
There was a problem hiding this comment.
Suggested change
| raise ValueError("specify either 'role' or 'roles' parameter, but not both") | |
| raise ValueError("Specify either 'role' or 'roles' parameter, but not both") |
trino/client.py
Outdated
Comment on lines
247
to
248
| elif role is None and roles is None: | ||
| return {} |
There was a problem hiding this comment.
I think this is no-op and can be removed.
hashhar
requested changes
Mar 3, 2023
1 task
Because catalog roles are rather a legacy concept. Only hive standard SQL leverages the catalog roles. All modern access systems use a single SYSTEM role. Most users are not aware about the catalog roles concept. Adding a single role will not confuse users but rather it will make the client more easy to use. |
damian3031
force-pushed
the
add-role-parameter
branch
from
e886aba
to
1319a18
Compare
hashhar
approved these changes
Apr 3, 2023
mdesmet
approved these changes
Apr 3, 2023
README.md
Outdated
| host='localhost', | ||
| port=443, | ||
| user='the-user', | ||
| roles="roleC" # equivalent to {"system": "roleC"} |
There was a problem hiding this comment.
I would advise against a mixed case example unless we are full sure it works in all cases.
damian3031
force-pushed
the
add-role-parameter
branch
from
1319a18
to
026e36f
Compare
hovaesco
approved these changes
Apr 3, 2023
hashhar
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added role parameter