Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bitwise_and_agg, bitwise_or_agg pushdown for Snowflake connector #21416

Closed
wants to merge 1 commit into from
Closed

Support bitwise_and_agg, bitwise_or_agg pushdown for Snowflake connector #21416

wants to merge 1 commit into from

Conversation

chenjian2664
Copy link
Contributor

Description

Additional context and related issues

Release notes

(x) Release notes are required, with the following suggested text:

# Snowflake
* Support pushdown bitwise_and_agg and bitwise_or_agg on bigint type column. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Apr 5, 2024
@github-actions github-actions bot added the docs label Apr 5, 2024
@ebyhr
Copy link
Member

ebyhr commented Apr 8, 2024

/test-with-secrets sha=055fc9f55f1dd3d194f02cd11eb60dbde8351e59

Copy link

github-actions bot commented Apr 8, 2024

The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/8593156612

@chenjian2664
Copy link
Contributor Author

2024-04-07T19:40:57.095-0600 WARN TestHangMonitor io.trino.testing.services.junit.LogTestDurationListener No test started or completed in 8.00m. Running tests:
TestSnowflakeConnectorTest.testInformationSchemaFiltering() running for 11.38m
JUnit Jupiter running for 14.67m
TestSnowflakeConnectorTest.testConstantUpdateWithVarcharInequalityPredicates() running for 8.65m
TestSnowflakeConnectorTest.testQueryLoggingCount() running for 8.08m
TestSnowflakeConnectorTest.testAddAndDropColumnName() running for 9.11m
TestSnowflakeConnectorTest running for 14.66m.

Is it because lacking the resources?

Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Apr 29, 2024
@chenjian2664 chenjian2664 requested a review from ebyhr May 13, 2024 13:07
@github-actions github-actions bot removed the stale label May 13, 2024
@ebyhr
Copy link
Member

ebyhr commented May 20, 2024

Could you rebase on master to resolve conflicts?

@chenjian2664
Copy link
Contributor Author

@ebyhr PTAL

Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added stale and removed stale labels Jun 13, 2024
Copy link

github-actions bot commented Jul 8, 2024

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Jul 8, 2024
@mosabua
Copy link
Member

mosabua commented Jul 8, 2024

Looks like this was rebased and is ready for @ebyhr @dprophet @yuuteng to look.

@mosabua mosabua requested review from dprophet and yuuteng July 8, 2024 17:23
@yuuteng
Copy link
Contributor

yuuteng commented Jul 9, 2024

I see that the build has failed in artifact-checks. As for the changes, they seem good for me.

@github-actions github-actions bot removed the stale label Jul 9, 2024
Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Jul 30, 2024
@github-actions github-actions bot removed the stale label Jul 31, 2024
@mosabua mosabua added the stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed. label Jul 31, 2024
@chenjian2664 chenjian2664 closed this by deleting the head repository Aug 14, 2024
@mosabua
Copy link
Member

mosabua commented Aug 26, 2024

@chenjian2664 are you replacing this PR with another PR from the new fork?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed docs stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed.
Development

Successfully merging this pull request may close these issues.

4 participants