Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for loading configuration from toml files #22983

Closed
wants to merge 1 commit into from

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Aug 8, 2024

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Aug 8, 2024
@wendigo wendigo requested review from electrum and Praveen2112 August 8, 2024 10:43
@wendigo wendigo force-pushed the serafin/toml branch 3 times, most recently from f48a70a to aacaa1b Compare August 8, 2024 12:08
@Praveen2112
Copy link
Member

Can we have some example/Environment which uses this toml file as a part of configuration ?

@wendigo
Copy link
Contributor Author

wendigo commented Aug 8, 2024

@Praveen2112 sure :)

@wendigo
Copy link
Contributor Author

wendigo commented Aug 8, 2024

@electrum question whether directionally this is a way to go?

@wendigo
Copy link
Contributor Author

wendigo commented Aug 8, 2024

@Praveen2112 here you go :)

@Praveen2112
Copy link
Member

Are we planning to replace properties file with toml in general or do we have have plans on replacing multiple files with a single toml file ? i.e instead of iterating over a catalog directory for the list catalogs to be created - We could iterate over a single TOML file for the same ?

Similarly multiple access connector can be configued via a single TOML file instead of multiple files configured as a part of config.properties i.e configured via access-control.config-files property

@electrum
Copy link
Member

I don't think we want to simply replace each properties file with TOML. Rather, we'd like to have a single TOML file for everything, so that server config, catalogs, access control, etc., can all be in the same file. Maybe catalogs would be separate, since that is pluggable.

Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Sep 17, 2024
@wendigo wendigo closed this Sep 17, 2024
@wendigo wendigo deleted the serafin/toml branch October 2, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants