Allow to pass step length in Loki connector #24862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
requested changes
Jan 31, 2025
plugin/trino-loki/src/main/java/io/trino/plugin/loki/LokiTableHandle.java
Outdated
Show resolved
Hide resolved
plugin/trino-loki/src/main/java/io/trino/plugin/loki/QueryRangeTableFunction.java
Outdated
Show resolved
Hide resolved
|
"Allow to pass step length in Loki connector." https://trino.io/development/process.html#pull-request-and-commit-guidelines-
|
jeschkies
force-pushed
the
karsten/loki-connector-step
branch
from
ec58c8a to
6bbaa72
Compare
jeschkies
changed the title
jeschkies
force-pushed
the
karsten/loki-connector-step
branch
from
6bbaa72 to
3221097
Compare
ebyhr
force-pushed
the
karsten/loki-connector-step
branch
from
3221097 to
c7cb42a
Compare
ebyhr
added
the
no-release-notes
ebyhr
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Loki API allows to pass the step length in seconds. This change updates the client and adds an optional
STEPparameter to the query range table function.This allows us to simplify the integration test as well.
Fixes #24861