Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP8 Warnings #46

Open
dsenalik opened this issue Dec 15, 2022 · 2 comments
Open

PHP8 Warnings #46

dsenalik opened this issue Dec 15, 2022 · 2 comments

Comments

@dsenalik
Copy link
Contributor

dsenalik commented Dec 15, 2022 •
edited
Loading

More warnings observed under PHP8 to be fixed

Pull Request #47
@dsenalik
Copy link
Contributor Author

dsenalik commented Dec 15, 2022 •
edited
Loading

Item 1 has the error message

Warning: Undefined variable $db in tripal_get_feature_blast_results() (line 116 of .../sites/all/modules/tripal_analysis_blast/api/tripal_analysis_blast.api.inc).

This happens if there are no blast hits for a particular feature. And under PHP8, this prevents the content page from rendering. But the fix is pretty simple.

Commit 1f65b8d fixes this.

@dsenalik dsenalik mentioned this issue Dec 15, 2022
Open
@dsenalik
Copy link
Contributor Author

Item 2 has the error message

Warning: Attempt to read property "value" on null in tripal_get_feature_blast_results() (line 84 of .../sites/all/modules/tripal_analysis_blast/api/tripal_analysis_blast.api.inc).

Commit a85e48e fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dsenalik