Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added multi hooks support #72

Closed

Conversation

iamkhalidbashir
Copy link
Contributor

Can be used as

 @BeforeCreateOne([
    getStringValidationHook<ITodo>(`name`, { min: 3, max: 10 }),
    getSetUserIdPropertyHook<ITodo>(`todoCreatedBy`),
  ])
  class Todo extends Base implements ITodo {
   ...
   ...

@iamkhalidbashir iamkhalidbashir marked this pull request as ready for review December 27, 2022 13:09
@iamkhalidbashir
Copy link
Contributor Author

Why isnt this still merged ?

@TriPSs
Copy link
Owner

TriPSs commented Apr 11, 2023

Because your tests are failing.

@iamkhalidbashir
Copy link
Contributor Author

Oh ok, I don't have time to fix these types of related issues, can you fix these? This merge will be very helpful to the community. I am using my own lib for my projects and would love to use this repo if this is merged. Best.

@TriPSs
Copy link
Owner

TriPSs commented Apr 11, 2023

Will try to check it out!

@TriPSs
Copy link
Owner

TriPSs commented Apr 13, 2023

Thanks for the PR, I will update the tests here #125

@TriPSs TriPSs closed this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants