Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failed for onig #264

Closed
elgunhuseynli opened this issue Sep 28, 2019 · 5 comments
Closed

Build failed for onig #264

elgunhuseynli opened this issue Sep 28, 2019 · 5 comments

Comments

@elgunhuseynli
Copy link

Examples aren't compiling on Windows 10.

Compiling onig_sys v69.2.0
error: failed to run custom build command for `onig_sys v69.2.0`
...
--- stdout
cargo:warning=couldn't execute `llvm-config --prefix` (error: The system cannot find the file specified. (os error 2))
cargo:warning=set the LLVM_CONFIG_PATH environment variable to a valid `llvm-config` executable
@elgunhuseynli
Copy link
Author

Oniguruma is regex library written in C. Why not just use Rust's own regex library? So we don't get build errors like that.

@keith-hall
Copy link
Collaborator

rust-onig/rust-onig#109

Why not just use Rust's own regex library?

see #12

@trishume
Copy link
Owner

See the new pure-Rust fancy-regex mode introduced in v4.0.0 to avoid this issue!

Still hoping that onig's build will eventually improve but for now fancy-regex is a good option.

@Enselic
Copy link
Collaborator

Enselic commented Oct 4, 2021

Duplicate of #12

@Enselic
Copy link
Collaborator

Enselic commented Oct 4, 2021

This issue can be closed with motivation:

Effectively a duplicate of #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants