Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid passing text through the new parser for legacy API methods #276

Open
diogotcorreia opened this issue Jan 1, 2023 · 0 comments
Open

Avoid passing text through the new parser for legacy API methods #276

diogotcorreia opened this issue Jan 1, 2023 · 0 comments
Labels
module:core Related to the core module regression Something that was working but it isn't anymore type:bug Something isn't working as expected
Milestone
4.0.0

Comments

@diogotcorreia
Copy link
Member

The old API methods, such as LanguageManager#getText are using the new Adventure parser, which removes the original color codes and might change their location.

People using the API might not account for this, since this was not the behaviour on v3.
To avoid this, just use simple string text-replacement for these methods, providing similar behaviour to v3.
@diogotcorreia diogotcorreia added type:bug Something isn't working as expected regression Something that was working but it isn't anymore module:core Related to the core module labels Jan 1, 2023
@diogotcorreia diogotcorreia added this to the 4.0.0 milestone Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module:core Related to the core module regression Something that was working but it isn't anymore type:bug Something isn't working as expected
Projects
Triton
Status: Todo
Milestone
4.0.0
Development

No branches or pull requests
1 participant
@diogotcorreia