Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read extra parameters on token response #76

Closed
poislagarde opened this issue Apr 14, 2016 · 4 comments
Closed

Read extra parameters on token response #76

poislagarde opened this issue Apr 14, 2016 · 4 comments

Comments

@poislagarde
Copy link
Contributor

Hi! My authorization server returns some extra parameters in the access token response and I need a way to read them.

For reference, check out example_parameter in this example in the spec

@bckr
Copy link
Contributor

bckr commented Apr 18, 2016

Hey @poislagarde!

Unfortunately there is currently no possibility to parse additional parameters. This would require externalizing the parsing of the access token response. We are currently not planning to extend Heimdallr with this functionality but would welcome any Pull Request! ☺️

@poislagarde
Copy link
Contributor Author

Thank you @bckr for responding! I'll try something out soon

@poislagarde
Copy link
Contributor Author

Can I get some feedback on this? Do you think something like my PR is the right approach? What should I do to get it merged? I'm open to suggestions.

Thanks!

@bckr
Copy link
Contributor

bckr commented Apr 26, 2016

@poislagarde Thanks for the quick pull request and sry for the late response! I'll have a look at the changes as soon as I'm back at my development machine 👍

@bckr bckr closed this as completed in #79 May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants