Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Taal: Compare performance of point-wise source terms against element-wise source terms #208

Closed
sloede opened this issue Oct 8, 2020 · 0 comments · Fixed by #276
Closed

Taal: Compare performance of point-wise source terms against element-wise source terms #208

sloede opened this issue Oct 8, 2020 · 0 comments · Fixed by #276
Assignees
@ranocha
Labels
good first issue Good for newcomers performance We are greedy taal

Comments

@sloede
Copy link
Member

sloede commented Oct 8, 2020

If point-wise source terms are sufficiently performant, we should only use those since they separate DG internals from equation-specific stuff. However, for this decision to make properly, we should run some 2D and, more importantly, 3D tests.
@sloede sloede added good first issue Good for newcomers performance We are greedy labels Oct 8, 2020
@sloede sloede mentioned this issue Oct 8, 2020
Merged
@ranocha ranocha changed the title Compare performance of point-wise source terms against element-wise source terms Taal: Compare performance of point-wise source terms against element-wise source terms Oct 9, 2020
@ranocha ranocha added the taal label Oct 9, 2020
@ranocha ranocha mentioned this issue Nov 2, 2020
Closed
44 tasks
@ranocha ranocha self-assigned this Nov 2, 2020
@ranocha ranocha mentioned this issue Nov 2, 2020
Merged
@ranocha ranocha linked a pull request Nov 2, 2020 that will close this issue
compare performance of source terms in 3D #276
Merged
@ranocha ranocha closed this as completed Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ranocha ranocha

Labels
good first issue Good for newcomers performance We are greedy taal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

compare performance of source terms in 3D ranocha/Trixi.jl
2 participants
@sloede @ranocha