Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_ldecomp breaks if on some offsets (128-255, 384-511, etc) #43

Closed
ChrisBeaumont67 opened this issue May 13, 2021 · 4 comments
Closed

_ldecomp breaks if on some offsets (128-255, 384-511, etc) #43

ChrisBeaumont67 opened this issue May 13, 2021 · 4 comments

Comments

@ChrisBeaumont67
Copy link
Contributor

It appears that the signed/unsigned handling in _ldecomp() leaves a few things in limbo...

Attaching a small code sample that highlights this (exhaustively), with an inline fix (a simple cast does wonders 😄)

_ldecomp.zip
@troglobit
Copy link
Owner

Interesting! Do you think you could whip up a patch or pull request?

@ChrisBeaumont67
Copy link
Contributor Author

ChrisBeaumont67 commented May 21, 2021 •
edited
Loading

[Sorry for the long delay]
I couldn't manage to actually create a PR (Cant push the branch!?!)
Resorting to a copy/paste (well that didn't work either... so zipped it comes)

Issue43.zip

@troglobit
Copy link
Owner

Thank you! I'll have a look at the ZIP later this weekend, I hope.

You have to fork the repo and push to your own fork, then create a pull request. This because I (and GitHub by default) don't allow anyone to push.

@troglobit
Copy link
Owner

There, sorry for taking so long to apply this to master!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@troglobit @ChrisBeaumont67