Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runstatedir is not defined in autoconf version 2.69 #6

Closed
fjaell opened this issue Nov 25, 2019 · 7 comments
Closed

runstatedir is not defined in autoconf version 2.69 #6

fjaell opened this issue Nov 25, 2019 · 7 comments

Comments

@fjaell
Copy link

fjaell commented Nov 25, 2019

latest released version of autoconf is 2.69 and does not define "runstatedir" which was added with commit

http://git.savannah.gnu.org/gitweb/?p=autoconf.git;a=commit;h=a197431414088a417b407b9b20583b2e8f7363bd

to autoconf after the 2.69 release. Running autoreconf on the sysklogd sources gives a broken source tree therefore.

Thanks.

@troglobit
Copy link
Owner

I'm just realizing the autoconf project has not made an official release since 2012 ... 😳

I'm using Ubuntu and Debian, where this seems to be supported. The sysklogd patch idea originally came fro Gentoo. So what system are you using?

Not sure how I should approach this bug report atm.

@troglobit
Copy link
Owner

As a background. The change in sysklogd configure.ac came about due to Gentoo using --localstatedir=/var/lib for all (?) configure based applications and sysklogd <2.0.1 simply appended /run to that, which on most systems works flawlessly since they set it to /var instead. I had my reservations but since --runstatedir worked on Gentoo and also on Debian & Ubuntu I went ahead with the change. I guess I could add more complexity to configure.ac but I'd much rather avoid that ... any ideas?

Original report is here https://bugs.gentoo.org/701048

@fjaell
Copy link
Author

fjaell commented Nov 26, 2019

As far as I can see gentoo solves the problem in the above bug-report differently and not by using --runstatedir because they don't use a autoconf with --runstatedir added.
Using /var/lib for --localstatedir seems wrong to me, though.
I'm using CRUX with a stock autoconf 2.69, a quick search shows me that arch, SUSE and LFS didn't patch autoconf for --runstatedir either.

My suggestion would be to revert the change or at least use $localstatedir/run for the PID location if runstatedir is not defined/used.

@troglobit
Copy link
Owner

Thanks for the feedback, will look into it as soon as possible!

@troglobit
Copy link
Owner

Should be fixed on master now, please let me know otherwise so we can reopen this issue. Thanks again for the report!

@fjaell
Copy link
Author

fjaell commented Nov 27, 2019

Yep, that works. Thanks a lot!

@troglobit
Copy link
Owner

Great, thank you for verifying! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants