A problem with a previous commit ?

[turiot]

Hello Oleg,

While recompiling trolCommander from develop branch I encounter an issue on Windows 10, the application can't open files.
It works when I revert commit 387e8ef ('Fixed command execution on Windows for path with whitespaces'), in WinNtDesktopAdapter.java, setting back FILE_OPENER_COMMAND to "cmd /c start "" "$f""

Is it my environnement, a lost commit, or something else ?

Thanks.

[trol73]

Hello,
Thanks for your message. As far as I remember, I made these changes because on my Windows 10 it was not possible to open a file located in a directory with spaces in the name. And this change solved the problem for me then.
But it turns out that the problem was not resolved at all..

[turiot]

Hi Oleg,
For me on windows 10 with the rollback, opening a file (launching a pdf external viewer, or an exe) works even with spaces in directory or file name.
Can I help with trying to recreate the same problematic configuration you got ?

[trol73]

Hi,
As far as I remember, I had a problem on Windows 10 when opening a file in the directory of which there was a space and Cyrillic characters. Like this "c:\Google Диск\some file.pdf"

[turiot]

привет,
I can't recreate the problem, on windows 10 + Java 16 + locale fr, a path like "c:\Google Диск\some file.pdf" works.