-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quasi memory leak in Gridstack._prepareElementByNode #505
Comments
radiolips
added a commit
to radiolips/gridstack.js
that referenced
this issue
Aug 17, 2016
…g `_.extend`. Fixes gridstack#505.
Merged
@DavidKDeutsch Wow. That was an amazing catch. I don't believe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Gridstack._prepareElementByNode uses _.extend to set the draggable options and whatnot on an added widget, e.g.:
This has the effect of modifying
this.opts.draggable
, setting its members to the same methods that are passed toel.draggable()
. Since these new methods referenceel
, the widget stays in memory even after it is removed. Probably not a huge deal, as only one widget can leak at a time (asthis.opts
will get overwritten with the new widget's options), but it can make for a frustrating search for a leak.The text was updated successfully, but these errors were encountered: