Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items lose "data-gs-y" styles when any item is resized horizontally. #744

Closed
Stratofish opened this issue Aug 21, 2017 · 4 comments
Closed
Labels

Comments

@Stratofish
Copy link

Stratofish commented Aug 21, 2017

This seems to happen only when the resized item is the only one on it's row. Resizing it vertically resets them.

https://jsfiddle.net/ad2e0hvm/12/

As far as I can see this is due to the fix for #600. _updateStyles() is meant to be incremental but that fix flat out deletes all the styles and only recreates the top (item height + 10) rows

@radiolips
Copy link
Member

This is bizarre. If you resize vertically and don't let go of click, you can still resize horizontally and it works fine. In my projects, I don't have this issue. I'll investigate, but I can't think of a good reason (which only means that it's a bad reason...but aren't all bugs bad?).

@radiolips
Copy link
Member

@Stratofish Could you try again with the latest develop branch code? I believe that an old PR that I just merged will fix this for you.

@nickxbs
Copy link

nickxbs commented Feb 21, 2018

I have the same problem, it seems fixed with the last dev version

@radiolips
Copy link
Member

Thanks, @nickxbs . I'm going to close the ticket - Let me know if you still have a problem, @Stratofish .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants