php#53: Fix async stream event optimization for TCP/UDP socket connections

        Add missing asynchronous connection support for TCP/UDP sockets in php_tcp_sockop_connect.
        Previously only Unix domain sockets used async when ZEND_ASYNC_IS_ACTIVE, while TCP/UDP
        always used synchronous php_network_connect_socket_to_host.

        Changes:
        - Add php_stream parameter to php_network_connect_socket_to_host()
        - Use network_async_connect_socket() when stream provided and ZEND_ASYNC_IS_ACTIVE
        - Update FTP extension call (pass NULL to remain synchronous)
        - Update socket streams call (pass stream to enable async)

Author: EdmondDantes

ext/ftp/ftp.c

@@ -123,7 +123,7 @@ ftpbuf_t* ftp_open(const char *host, short port, zend_long timeout_sec)
 
 	ftp->fd = php_network_connect_socket_to_host(host,
 			(unsigned short) (port ? port : 21), SOCK_STREAM,
-			0, &tv, NULL, NULL, NULL, 0, STREAM_SOCKOP_NONE);
+			0, &tv, NULL, NULL, NULL, 0, STREAM_SOCKOP_NONE, NULL);
 	if (ftp->fd == -1) {
 		goto bail;
 	}

main/network.c

@@ -834,7 +834,8 @@ PHPAPI php_socket_t php_network_accept_incoming(php_socket_t srvsock,
 /* {{{ php_network_connect_socket_to_host */
 php_socket_t php_network_connect_socket_to_host(const char *host, unsigned short port,
 		int socktype, int asynchronous, struct timeval *timeout, zend_string **error_string,
-		int *error_code, const char *bindto, unsigned short bindport, long sockopts
+		int *error_code, const char *bindto, unsigned short bindport, long sockopts,
+		php_stream *stream
 		)
 {
 	int num_addrs, n, fatal = 0;
@@ -958,9 +959,15 @@ php_socket_t php_network_connect_socket_to_host(const char *host, unsigned short
 			}
 		}
 #endif
-		n = php_network_connect_socket(sock, sa, socklen, asynchronous,
-				timeout ? &working_timeout : NULL,
-				error_string, error_code);
+		if (ZEND_ASYNC_IS_ACTIVE && stream != NULL) {
+			n = network_async_connect_socket(stream, sock, sa, socklen, asynchronous,
+					timeout ? &working_timeout : NULL,
+					error_string, error_code);
+		} else {
+			n = php_network_connect_socket(sock, sa, socklen, asynchronous,
+					timeout ? &working_timeout : NULL,
+					error_string, error_code);
+		}
 
 		if (n != -1) {
 			goto connected;

main/php_network.h

@@ -280,7 +280,8 @@ PHPAPI void php_network_freeaddresses(struct sockaddr **sal);
 
 PHPAPI php_socket_t php_network_connect_socket_to_host(const char *host, unsigned short port,
 		int socktype, int asynchronous, struct timeval *timeout, zend_string **error_string,
-		int *error_code, const char *bindto, unsigned short bindport, long sockopts
+		int *error_code, const char *bindto, unsigned short bindport, long sockopts,
+		php_stream *stream
 		);
 
 PHPAPI int php_network_connect_socket(php_socket_t sockfd,

main/streams/xp_socket.c

@@ -980,7 +980,8 @@ static inline int php_tcp_sockop_connect(php_stream *stream, php_netstream_data_
 			&err,
 			bindto,
 			bindport,
-			sockopts
+			sockopts,
+			stream
 			);
 
 	ret = sock->socket == -1 ? -1 : 0;