php#53: Optimize network_async_set_socket_blocking to return bool

         Changed network_async_set_socket_blocking from void to bool return type
         to eliminate redundant EG(exception) checks. Function now returns false
         on error instead of requiring separate exception checking.

         Updated 3 call sites:
         - php_sockop_write() in xp_socket.c
         - sock_async_poll() in xp_socket.c
         - network_async_accept_incoming() in network_async.c

         This reduces code duplication and improves performance by combining
         function call and error check into single conditional.

Author: EdmondDantes

main/network_async.c

@@ -63,17 +63,17 @@ static zend_always_inline zend_ulong poll2_events_to_async(const short events);
  * @param blocking
  * @param sock_data
  */
-void network_async_set_socket_blocking(php_socket_t socket, bool blocking, php_netstream_data_t *sock_data)
+bool network_async_set_socket_blocking(php_socket_t socket, bool blocking, php_netstream_data_t *sock_data)
 {
 	// Optimization: avoid redundant system calls if the socket is already in the desired mode
 	if (sock_data != NULL) {
 		if (!blocking && sock_data->nonblocking_applied) {
 			// Already in non-blocking mode, skip system call
-			return;
+			return true;
 		}
 		if (blocking && !sock_data->nonblocking_applied) {
 			// Already in blocking mode, skip system call
-			return;
+			return true;
 		}
 	}
 
@@ -86,7 +86,7 @@ void network_async_set_socket_blocking(php_socket_t socket, bool blocking, php_n
 			ZEND_ASYNC_EXCEPTION_DEFAULT,
 			"ioctlsocket(FIONBIO) failed (WSA error %d)", err
 		);
-		return;
+		return false;
 	}
 #else
 	int flags = fcntl(socket, F_GETFL, 0);
@@ -97,7 +97,7 @@ void network_async_set_socket_blocking(php_socket_t socket, bool blocking, php_n
 			"fcntl(F_GETFL) failed: %s", strerror(errno)
 		);
 
-		return;
+		return false;
 	}
 
 	int new_flags = blocking ? (flags & ~O_NONBLOCK) : (flags | O_NONBLOCK);
@@ -107,14 +107,16 @@ void network_async_set_socket_blocking(php_socket_t socket, bool blocking, php_n
 			ZEND_ASYNC_EXCEPTION_DEFAULT,
 			"fcntl(F_SETFL) failed: %s", strerror(errno)
 		);
-		return;
+		return false;
 	}
 #endif
 
 	// Update the flag to reflect the actual socket state
 	if (sock_data != NULL) {
 		sock_data->nonblocking_applied = !blocking;
 	}
+
+	return true;
 }
 
 bool network_async_ensure_socket_nonblocking(php_socket_t socket)
@@ -1142,8 +1144,7 @@ ZEND_API php_socket_t network_async_accept_incoming(php_netstream_data_t *netdat
 
 	// Ensure socket is in non-blocking mode for async operations
 	if (netdata->is_blocked && !netdata->nonblocking_applied) {
-		network_async_set_socket_blocking(netdata->socket, false, netdata);
-		if (UNEXPECTED(EG(exception) != NULL)) {
+		if (UNEXPECTED(!network_async_set_socket_blocking(netdata->socket, false, netdata))) {
 			goto return_error;
 		}
 	}

main/network_async.h

@@ -20,7 +20,7 @@
 
 BEGIN_EXTERN_C()
 
-ZEND_API void network_async_set_socket_blocking(php_socket_t socket, bool blocking, php_netstream_data_t *sock_data);
+ZEND_API bool network_async_set_socket_blocking(php_socket_t socket, bool blocking, php_netstream_data_t *sock_data);
 ZEND_API bool network_async_ensure_socket_nonblocking(php_socket_t socket);
 ZEND_API void network_async_wait_socket(php_socket_t socket, const zend_ulong events, const zend_ulong timeout);
 ZEND_API int network_async_await_stream_socket(php_netstream_data_t *netdata, async_poll_event events, struct timeval *timeout);

main/streams/xp_socket.c

@@ -72,8 +72,7 @@ static ssize_t php_sockop_write(php_stream *stream, const char *buf, size_t coun
 		ptimeout = &sock->timeout;
 
 	if (ZEND_ASYNC_IS_ACTIVE && sock->is_blocked && !sock->nonblocking_applied) {
-		network_async_set_socket_blocking(sock->socket, false, sock);
-		if (UNEXPECTED(EG(exception) != NULL)) {
+		if (UNEXPECTED(!network_async_set_socket_blocking(sock->socket, false, sock))) {
 			/* If we are in async context and an exception was thrown, we should not continue. */
 			return -1;
 		}
@@ -351,8 +350,7 @@ static int php_sockop_stat(php_stream *stream, php_stream_statbuf *ssb)
 static inline int sock_async_poll(php_netstream_data_t *sock, async_poll_event poll_events)
 {
 	if (UNEXPECTED(sock->is_blocked && !sock->nonblocking_applied && ZEND_ASYNC_IS_ACTIVE)) {
-		network_async_set_socket_blocking(sock->socket, false, sock);
-		if (UNEXPECTED(EG(exception) != NULL)) {
+		if (UNEXPECTED(!network_async_set_socket_blocking(sock->socket, false, sock))) {
 			return -1;
 		}
 	}