-
-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[common] Dont load fixed middlewares if not found or not enabling treafik integration by default #28996
Comments
@stavros-k You wrote most of this, so I've assigned it to your for feedback and convenience. |
traefik integration is:
Fixed middlewares are:
if namespace is given, we use that, otherwise we try to For this we can do either:
tbh I don't like silently ignoring. |
@stavros-k I would say:
It moves logic from traefik -> common and ensure we would never have to rely on cross-namespace lookups |
Cool. I think first would be to make a class/spawner for middlewares. |
correct |
|
Is your feature request related to a problem?
Currently I think we try-to load fixed-middleware, even if they are not found.
This means our ingress (without disabling the integration code), is inherently not compatible with upstream treafik, which makes it less easy for non-truecharts-centered users to use TrueCharts common in their clusters.
Describe the solution you'd like
Not loading fixed-middlewares if they are not found/present and the treafik namespace is not set.
Describe alternatives you've considered
Not enabling the integration by default.
Which is a serieus option we should consider for compatibility tbh.
Additional context
No response
I've read and agree with the following
The text was updated successfully, but these errors were encountered: