Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Add tests to check for eth_call side effects #2934

Closed
MicaiahReid opened this issue Apr 19, 2022 · 2 comments
Closed

Add tests to check for eth_call side effects #2934

MicaiahReid opened this issue Apr 19, 2022 · 2 comments

Comments

@MicaiahReid
Copy link
Contributor

If i'm not \wrong about the above then we don't yet have exhaustive tests that check if eth_call has side effects and we should add those.

Originally posted by @davidmurdoch in #2565 (comment)

@davidmurdoch
Copy link
Member

We do have a test ("does not create a transaction on the chain" -- which is not a very robust test). The new code introduced in #2565 modifies state directly now, so we need to be extra careful that those state changes don't stick around.

@davidmurdoch
Copy link
Member

I think we can consider this as implemented in #2565

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants