Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async as an identifier causes parser issues #124

Closed
nxproject opened this issue Aug 18, 2020 · 6 comments
Closed

async as an identifier causes parser issues #124

nxproject opened this issue Aug 18, 2020 · 6 comments

Comments

@nxproject
Copy link

If you look at Xhr.js line 860 and compare that to cXhr.js column 1157, you will see the generated code, except the code at cXhr.js that precedes it comes from Xhr.js line 223.

I may have other issues, but the cascade from this one makes things unclear.

Thank you for your time.

Issues.zip

@trullock
Copy link
Owner

I'm gonna need a much more succinct example, with input, expected output, actual output and NUglify parameters.

What are you saying is wrong?

@nxproject
Copy link
Author

I do not believe that I can come up with a succinct example, as I believe that the complexity of the JavaScript code is what is causing it. I have tested other minifiers and they all seem to work fine, so I am closing this. Thank you for your time.

@trullock
Copy link
Owner

If theres an issue I'm keen to understand it.

Can you at least tell me what you think is wrong?

@nxproject
Copy link
Author

The logic mapped calls to __checkDisposed into calls to __initNativeXhr.

That is the first error, as there seem to be more as the mnfied code that NUglify is producing is totally different from other minifiers.

FYI:  This may be happening in a handful of the 600+ scripts that I have minfied.  As I could not trust the NUglify output and due to the dynamic nature of the project that I am working on, I had to switch to another minifier so it would be difficult to reproduce all instances.

Again, thank you for your time.

@trullock trullock changed the title Incorrect Js being generated async as an identifier causes parser issues Aug 21, 2020
@trullock
Copy link
Owner

This is the same issue as #80
I'll look at fixing it

@trullock
Copy link
Owner

Published 1.6.6 with a fix for this in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants