Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biome gets stuck processing its own config file #867

Open
noxan opened this issue Sep 10, 2024 · 5 comments
Open

Biome gets stuck processing its own config file #867

noxan opened this issue Sep 10, 2024 · 5 comments

Comments

@noxan
Copy link

noxan commented Sep 10, 2024

when running trunk check --all biome gets stuck processing its own config file

Screenshot 2024-09-10 at 10 07 24 AM
@TylerJang27
Copy link
Collaborator

Hi @noxan! Sorry you're running into this issue. This could be related to another known issue where some batched linters can occasionally hang on their execution (we're looking into it).

If you run the following, does the issue resolve itself?

trunk daemon shutdown
trunk check -a --filter=biome

@noxan
Copy link
Author

noxan commented Sep 10, 2024

@TylerJang27 thanks for the swift reply, sadly the problem persists. it seems other json files also can cause complications, but i'm actually having a hard time to reproduce it - the biome.json config file remains a persistent issue.

i also tried to ignore the file via trunk.yml -> lint.ignore.linters.paths i receive the following error instead:

 46:11  high  '.trunk/config/biome.json' does not exist  trunk/config-error
Unable to run check due to invalid config

@TylerJang27
Copy link
Collaborator

I'll look into this issue further, but it looks like you have a typo: .trunk/config/biome.json -> .trunk/configs/biome.json

@TylerJang27
Copy link
Collaborator

@noxan can you also include what Trunk version and what biome version you are running?

@noxan
Copy link
Author

noxan commented Sep 11, 2024

@TylerJang27 we are running trunk version 1.22.2 and biome we tested latest 1.8.3 and downgraded to 1.4.1 as a fallback option (the unknown working version listed in the plugin config).

Thanks for pointing out the typo, we settled for the following meanwhile:

    - linters: [biome]
      paths:
        - ".trunk/configs"

This seems to get biome unstuck and also covers the edge case of having comments in the tsconfig.json file, which shouldn't have comments but their boilerplate does have comments in json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants