-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider switching paths to use native slices #48
Comments
And if we stick with |
We discussed this again and came to the conclusion that it makes more sense to have a |
One issue that remains (and that is currently not checked everywhere), is that path should not be longer than And the |
The question is whether we need this restriction in |
I think we need it for Most path creation will either be done through the |
The methods that pass |
The null-terminated C strings used in Littlefs2 are annoying to use and lead to inefficient iteration and higher stack usage because of the lack of ability to slice, which means copying to buffer is often required.
The bindings could instead create a stack buffer and copy rust slices to them when required just before the call to the C bindings.
This would make manipulation of path much more ergonomic.
The text was updated successfully, but these errors were encountered: