Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename sale package_weight to weight #4

Open
prakashpp opened this issue Aug 2, 2015 · 1 comment
Open

Rename sale package_weight to weight #4

prakashpp opened this issue Aug 2, 2015 · 1 comment

Comments

@prakashpp
Copy link
Contributor

package weight field is misguiding[1], we have already made similar change to shipment and package model. With this downstream modules also need to be change.

[1] https://github.com/fulfilio/trytond-shipping/blob/develop/sale.py#L22

@sharoonthomas
Copy link
Contributor

@prakashpp we should deprecate this step by step. As a first step add another field named total_weight and the have the getter of package_weight issue a deprecation warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants